From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: PATCH: fix for memory corruption and eventual crash in print.c Date: Mon, 07 Jul 2008 19:03:55 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <871w27unls.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1215425120 8351 80.91.229.12 (7 Jul 2008 10:05:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Jul 2008 10:05:20 +0000 (UTC) Cc: Ami Fischman , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 07 12:06:07 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KFnan-0007gH-NX for ged-emacs-devel@m.gmane.org; Mon, 07 Jul 2008 12:05:26 +0200 Original-Received: from localhost ([127.0.0.1]:46755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFnZw-0008Ki-Ej for ged-emacs-devel@m.gmane.org; Mon, 07 Jul 2008 06:04:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KFnZi-0008Kc-Nh for emacs-devel@gnu.org; Mon, 07 Jul 2008 06:04:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KFnZe-0008KQ-Nk for emacs-devel@gnu.org; Mon, 07 Jul 2008 06:04:01 -0400 Original-Received: from [199.232.76.173] (port=57994 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFnZe-0008KN-4i for emacs-devel@gnu.org; Mon, 07 Jul 2008 06:03:58 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:62010 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KFnZd-0000nr-Jo for emacs-devel@gnu.org; Mon, 07 Jul 2008 06:03:57 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 6CA152C45; Mon, 7 Jul 2008 19:03:55 +0900 (JST) In-Reply-To: <871w27unls.fsf@stupidchicken.com> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/23.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100414 Archived-At: >>>>> On Sun, 06 Jul 2008 09:51:59 -0400, Chong Yidong said: > YAMAMOTO Mitsuharu writes: >> I think a fix for `print_object' should go to the EMACS_22_BASE branch >> as well as the trunk so it may not be missed. Another candidate for >> the inclusion to the EMACS_22_BASE branch would be the PNG background >> color bit-depth fix below: >> >> 2008-05-09 Chong Yidong >> >> * image.c (png_load): Use correct bit-depth for setting background >> color. > Yes. Could someone please check it into the branch? Thanks. Done for `png_load'. For the `print_object' patch offered by the OP, I'd like to leave it to experts on this area. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp