From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: "Jan D." <jan.h.d@swipnet.se>, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [hober0@gmail.com: Re: mode-line redisplay bug]
Date: Tue, 11 Oct 2005 10:21:33 +0900 [thread overview]
Message-ID: <wl4q7odf1e.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <ubr1xxisd.fsf@jasonrumney.net> <wlwtp6ijoz.wl%mituharu@math.s.chiba-u.ac.jp>
>>>>> On Mon, 10 Oct 2005 20:40:18 +0100, Jason Rumney <jasonr@gnu.org> said:
> "Jan D." <jan.h.d@swipnet.se> writes:
>> AFAIK co-ordinates on W32 behave the same as on X, so your patch
>> should be OK. It is easy to confirm anyway.
> OK, I've installed the patch, but as YAMAMOTO Mitsuharu pointed out,
> it may not deal with the left fringe width - which might be an
> explanation for the gx calculation being off by one, and possibly
> also the explanation for why this patch does work as I expected.
A simple debug code below shows the incorrectness of the calculated
rectangle :-). And if it is corrected, the problem I said in
http://lists.gnu.org/archive/html/emacs-pretest-bug/2005-06/msg00148.html
will appear.
>>>>> On Tue, 07 Jun 2005 18:45:48 +0900, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> said:
> 2.1 Sometimes a tooltip is not shown. I hope the first
> fragment of the patch below fix this.
> 2.2 The value of last_mouse_glyph may become invalid. For
> example, after clicking the image on the splash screen,
> dragging the area where the image was displayed does not
> issue mouse-movement events. I think last_mouse_glyph
> should be cleared in some appropriate timing, but I'm not
> sure when it is.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
Index: src/xterm.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xterm.c,v
retrieving revision 1.879
diff -c -r1.879 xterm.c
*** src/xterm.c 10 Oct 2005 22:54:19 -0000 1.879
--- src/xterm.c 11 Oct 2005 01:10:58 -0000
***************
*** 3675,3680 ****
--- 3677,3688 ----
rect->height = r->height;
rect->x = WINDOW_TO_FRAME_PIXEL_X (w, gx);
rect->y = WINDOW_TO_FRAME_PIXEL_Y (w, r->y);
+
+ XDrawRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
+ f->output_data.x->normal_gc,
+ rect->x - 1, rect->y - 1,
+ rect->width + 2, rect->height + 2);
+
return 1;
}
break;
next prev parent reply other threads:[~2005-10-11 1:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-12 14:59 [hober0@gmail.com: Re: mode-line redisplay bug] Richard M. Stallman
2005-08-12 16:58 ` Eli Zaretskii
2005-08-12 17:19 ` Edward O'Connor
2005-08-12 17:31 ` Edward O'Connor
2005-08-12 18:58 ` Henrik Enberg
2005-08-16 12:58 ` Kim F. Storm
2005-08-12 18:19 ` Robert J. Chassell
2005-08-12 22:56 ` Jason Rumney
2005-08-13 21:54 ` Richard M. Stallman
2005-08-13 22:51 ` Jason Rumney
2005-10-08 21:26 ` Jason Rumney
2005-10-09 1:57 ` mituharu
2005-10-09 6:11 ` Jan D.
2005-10-10 19:40 ` Jason Rumney
[not found] ` <wlwtp6ijoz.wl%mituharu@math.s.chiba-u.ac.jp>
2005-10-11 1:21 ` YAMAMOTO Mitsuharu [this message]
2005-10-11 10:21 ` Kim F. Storm
2005-10-11 12:38 ` YAMAMOTO Mitsuharu
2005-10-11 15:14 ` Kim F. Storm
2005-10-11 14:50 ` Jason Rumney
2005-10-11 22:43 ` Kim F. Storm
2005-10-12 3:15 ` YAMAMOTO Mitsuharu
2005-10-12 8:39 ` Kim F. Storm
2005-10-12 8:41 ` YAMAMOTO Mitsuharu
2005-10-12 9:29 ` Kim F. Storm
2005-10-12 9:59 ` YAMAMOTO Mitsuharu
2005-10-11 10:47 ` Jason Rumney
2005-10-11 11:25 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wl4q7odf1e.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).