From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: fixing non-NS darwin Date: Mon, 04 Aug 2008 12:49:59 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <200808011544.m71Fi4UD026726@sallyv1.ics.uci.edu> <200808011605.m71G5Wmb010785@sallyv1.ics.uci.edu> <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu> <200808040120.m741K6YQ001518@sallyv1.ics.uci.edu> <200808040226.m742QOgN023296@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1217821815 4744 80.91.229.12 (4 Aug 2008 03:50:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Aug 2008 03:50:15 +0000 (UTC) Cc: Adrian Robert , Emanuele Giaquinta , Emacs Development To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 04 05:51:05 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KPr69-0007H9-8F for ged-emacs-devel@m.gmane.org; Mon, 04 Aug 2008 05:51:05 +0200 Original-Received: from localhost ([127.0.0.1]:40603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPr5E-0000Cl-5l for ged-emacs-devel@m.gmane.org; Sun, 03 Aug 2008 23:50:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KPr5A-0000Cg-RM for emacs-devel@gnu.org; Sun, 03 Aug 2008 23:50:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KPr58-0000CU-AU for emacs-devel@gnu.org; Sun, 03 Aug 2008 23:50:03 -0400 Original-Received: from [199.232.76.173] (port=40012 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPr58-0000CR-6t for emacs-devel@gnu.org; Sun, 03 Aug 2008 23:50:02 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:50327 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KPr57-00071u-Er for emacs-devel@gnu.org; Sun, 03 Aug 2008 23:50:01 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id B75C62C46; Mon, 4 Aug 2008 12:49:59 +0900 (JST) In-Reply-To: <200808040226.m742QOgN023296@sallyv1.ics.uci.edu> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.2.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102023 Archived-At: >>>>> On Sun, 03 Aug 2008 19:26:24 -0700, Dan Nicolaescu said: >> It's quite a common way in the Emacs code to comment out with #if 0 >> with leaving some explanation about why it is disabled. Especially >> for the case that people might make the same mistake again in >> future unconsciously if that part were completely removed. > So? Everyone is aware of that. But that was absolutely not the case > in this particular instance. The comments and code did not make the > intention clear for the casual reader. Would casual readers care about admin/CPP-DEFINES? Anyway, I did not expect casual readers would touch the code in the CVS, even for cleanups. > If you actually want to contribute something positive, please add > the missing documentation and fix the code. It's not just a local problem. I'm concerned about possible removals of other important comments in your past/future cleanups. It's really inefficient if every developer has to check the excessive removal of comments in (inherently optional) cleanups. >> Cleanup tasks are usually tedious, and thus would be much >> appreciated if done carefully and appropriately. But as they are >> also inherently optional, not appreciated if done less carefully or >> unnecessarily aggressively as in the case of MULTI_KBOARD. > Did you just wait for an occasion to attack me on an unrelated item? > Grow up! Unrelated? I'd rather think these troubles come from the same mindset. Did I wait? I hoped such kind of troubles wouldn't happen again, but actually I could anticipate that would. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp