From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Adrian Robert <adrian.b.robert@gmail.com>,
Emanuele Giaquinta <emanuele.giaquinta@gmail.com>,
Emacs Development <emacs-devel@gnu.org>
Subject: Re: fixing non-NS darwin
Date: Mon, 04 Aug 2008 12:49:59 +0900 [thread overview]
Message-ID: <wl3allmobc.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <200808040226.m742QOgN023296@sallyv1.ics.uci.edu>
>>>>> On Sun, 03 Aug 2008 19:26:24 -0700, Dan Nicolaescu <dann@ics.uci.edu> said:
>> It's quite a common way in the Emacs code to comment out with #if 0
>> with leaving some explanation about why it is disabled. Especially
>> for the case that people might make the same mistake again in
>> future unconsciously if that part were completely removed.
> So? Everyone is aware of that. But that was absolutely not the case
> in this particular instance. The comments and code did not make the
> intention clear for the casual reader.
Would casual readers care about admin/CPP-DEFINES? Anyway, I did not
expect casual readers would touch the code in the CVS, even for
cleanups.
> If you actually want to contribute something positive, please add
> the missing documentation and fix the code.
It's not just a local problem. I'm concerned about possible removals
of other important comments in your past/future cleanups. It's really
inefficient if every developer has to check the excessive removal of
comments in (inherently optional) cleanups.
>> Cleanup tasks are usually tedious, and thus would be much
>> appreciated if done carefully and appropriately. But as they are
>> also inherently optional, not appreciated if done less carefully or
>> unnecessarily aggressively as in the case of MULTI_KBOARD.
> Did you just wait for an occasion to attack me on an unrelated item?
> Grow up!
Unrelated? I'd rather think these troubles come from the same
mindset. Did I wait? I hoped such kind of troubles wouldn't happen
again, but actually I could anticipate that would.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
next prev parent reply other threads:[~2008-08-04 3:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200808011544.m71Fi4UD026726@sallyv1.ics.uci.edu>
[not found] ` <E465D318-490F-44DB-B8E2-04227EE9498A@gmail.com>
[not found] ` <200808011605.m71G5Wmb010785@sallyv1.ics.uci.edu>
[not found] ` <B6D54F89-C459-46DD-BEEA-DB723F7A725E@gmail.com>
[not found] ` <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu>
2008-08-03 16:41 ` fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) Adrian Robert
2008-08-04 0:23 ` YAMAMOTO Mitsuharu
2008-08-04 1:20 ` fixing non-NS darwin Dan Nicolaescu
2008-08-04 2:03 ` YAMAMOTO Mitsuharu
2008-08-04 2:26 ` Dan Nicolaescu
2008-08-04 3:49 ` YAMAMOTO Mitsuharu [this message]
2008-08-04 4:02 ` Dan Nicolaescu
2008-08-04 9:08 ` Thien-Thi Nguyen
2008-08-04 11:53 ` Dan Nicolaescu
2008-08-04 1:11 ` Dan Nicolaescu
2008-08-04 16:11 ` fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) Adrian Robert
2008-08-04 17:31 ` fixing non-NS darwin Dan Nicolaescu
2008-08-05 9:21 ` fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) YAMAMOTO Mitsuharu
2008-08-04 13:59 ` Adrian Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wl3allmobc.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=adrian.b.robert@gmail.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=emanuele.giaquinta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).