From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Low redisplay performance (23 regression) Date: Thu, 30 Apr 2009 15:27:02 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <4870CC42-A08E-4BE9-B566-0F4DA7AB0B74@gmail.com> <878wlj228q.fsf@freebits.de> <87r5zb4auv.fsf@thinkpad.tsdh.de> <24EC426D-D6DA-438B-B794-72C123142235@gmail.com> <87zldzcn8q.fsf@cyd.mit.edu> <87ljpi4x7s.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1241072852 4118 80.91.229.12 (30 Apr 2009 06:27:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Apr 2009 06:27:32 +0000 (UTC) Cc: David Reitter , Tassilo Horn , Miles Bader , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 30 08:27:22 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LzPjs-0007Fc-KU for ged-emacs-devel@m.gmane.org; Thu, 30 Apr 2009 08:27:20 +0200 Original-Received: from localhost ([127.0.0.1]:46003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzPjr-0003z0-Qm for ged-emacs-devel@m.gmane.org; Thu, 30 Apr 2009 02:27:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzPjn-0003yI-EE for emacs-devel@gnu.org; Thu, 30 Apr 2009 02:27:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LzPji-0003vS-Hv for emacs-devel@gnu.org; Thu, 30 Apr 2009 02:27:14 -0400 Original-Received: from [199.232.76.173] (port=50243 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzPji-0003vP-CX for emacs-devel@gnu.org; Thu, 30 Apr 2009 02:27:10 -0400 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:50382) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LzPjg-0002gV-C5; Thu, 30 Apr 2009 02:27:08 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 4134D2C43; Thu, 30 Apr 2009 15:27:02 +0900 (JST) In-Reply-To: <87ljpi4x7s.fsf@cyd.mit.edu> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110568 Archived-At: >>>>> On Wed, 29 Apr 2009 23:49:43 -0400, Chong Yidong said: >> Some profiling results show that many Lisp objects are constructed >> in font_clear_prop, and that causes frequent GC triggered by Lisp >> evaluations in redisplay such as mode/header-line calculation. >> That would also explain why the OP doesn't observe the slowness on >> Emacs 22 with backported face remapping. > That's surprising. I have experimented with making font_clear_prop > overwrite font specs instead of allocating new ones, when possible. > However, this does not seem to improve performance (I do not intend > to change this for 23.1). I think the fundamental problem does not > lie in font_clear_prop, but in the fact that the face remapping > code's lookup_basic_face function calls lookup_named_face -> > merge_face_vectors far too often. I confirmed that your latest change lowered the frequency of GC, though I'm not sure which allocation is reduced most. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp