From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Display performance degradation Date: Sun, 20 Dec 2009 15:27:00 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <4B2A5F92.9090008@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1261290450 23531 80.91.229.12 (20 Dec 2009 06:27:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Dec 2009 06:27:30 +0000 (UTC) Cc: emacs-devel@gnu.org, Kenichi Handa To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 20 07:27:23 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NMFGD-0005QB-UW for ged-emacs-devel@m.gmane.org; Sun, 20 Dec 2009 07:27:22 +0100 Original-Received: from localhost ([127.0.0.1]:49059 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NMFGD-00088n-Ls for ged-emacs-devel@m.gmane.org; Sun, 20 Dec 2009 01:27:21 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NMFG5-00088W-8d for emacs-devel@gnu.org; Sun, 20 Dec 2009 01:27:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NMFFz-00084r-EH for emacs-devel@gnu.org; Sun, 20 Dec 2009 01:27:11 -0500 Original-Received: from [199.232.76.173] (port=41456 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NMFFz-00084o-30 for emacs-devel@gnu.org; Sun, 20 Dec 2009 01:27:07 -0500 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:63111 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NMFFy-0003kc-HE for emacs-devel@gnu.org; Sun, 20 Dec 2009 01:27:07 -0500 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 58827C0562; Sun, 20 Dec 2009 15:27:00 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118743 Archived-At: >>>>> On Sat, 19 Dec 2009 11:00:56 +0100, Andreas Schwab said: > YAMAMOTO Mitsuharu writes: >> 4490 if (XINT (XCAR (val)) == 0) >> 4491 { >> 4492 font_clear_cache (f, XCAR (val), driver_list->driver); >> 4493 XSETCDR (cache, XCDR (val)); >> 4494 } >> 4495 } >> >> At line 4490, XCAR (val) is expected to be of type Lisp integer. But >> it is also passed to font_clear_cache at line 4492, which seems to >> expect the value of `val' as of line 4488 rather than the one assigned >> at line 4489. > If the condition is ever true then Emacs crashes. I've checked in a > fix. But then, I don't think this function is ever more than a no-op > anyway, since as soon as NUM-FRAMES becomes zero the cache is cleared > automatically anyway. That's another reason I posted it rather than installing a trivial fix myself silently. If the code has never be executed, it might contain more hidden problems than those can easily be found with simple type checking by hand. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp