From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Toolbar patch (OS X) Date: Tue, 27 Sep 2005 12:43:58 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <5E6B6577-653A-4DCF-AC6A-10EC020C3548@gmail.com> <8764so3r5i.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1127794714 16826 80.91.229.2 (27 Sep 2005 04:18:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 27 Sep 2005 04:18:34 +0000 (UTC) Cc: David Reitter , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 27 06:18:24 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EK6ug-0005Fr-SZ for ged-emacs-devel@m.gmane.org; Tue, 27 Sep 2005 06:17:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EK6ug-0003X8-AA for ged-emacs-devel@m.gmane.org; Tue, 27 Sep 2005 00:17:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EK6s8-0002j8-Uw for emacs-devel@gnu.org; Tue, 27 Sep 2005 00:15:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EK6q1-00021h-QJ for emacs-devel@gnu.org; Tue, 27 Sep 2005 00:13:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EK6pn-0001qX-L9 for emacs-devel@gnu.org; Tue, 27 Sep 2005 00:12:51 -0400 Original-Received: from [133.82.132.2] (helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EK6Ns-00021P-6h for emacs-devel@gnu.org; Mon, 26 Sep 2005 23:44:00 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id B70042CAA; Tue, 27 Sep 2005 12:43:58 +0900 (JST) Original-To: Stefan Monnier In-Reply-To: <8764so3r5i.fsf-monnier+emacs@gnu.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/22.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:43277 Archived-At: >>>>> On Mon, 26 Sep 2005 09:17:26 -0400, Stefan Monnier said: >> I'm attaching a patch which enables the toolbar button in the upper >> right corner of each frame. This button is standard in OS X >> applications and allows users to switch the toolbar on and off per >> frame. The actual tool-bar switching functionality is already >> present (frame parameter tool-bar-lines), here I'm just enabling >> the button and its event-handling. >> This has been in use in a couple of Aquamacs versions (>1500 users >> currently), and the Japanese Carbon Emacs Package is using it too. > I haven't looked at the code, but the functionality would be > welcome. One thing I'm concerned about is whether TOGGLE_TOOLBAR_EVENT deserves a new constant in `enum event_kind' (in termhooks.h) or not. Likewise for `toggle-frame-toolbar' as a top-level Lisp event. Are there any guidelines about addition of new event kinds? Once Kim F. Storm suggested the `title-bar' prefix. http://lists.gnu.org/archive/html/emacs-devel/2004-05/msg00780.html And as a general note, please enclose Mac OS X specific parts in macfns.c and macterm.c with `#ifdef MAC_OSX' because these files are also used by Mac OS Classic. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp