From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: drkm Newsgroups: gmane.emacs.devel Subject: Ignoring file local-variables in patches? Date: Wed, 05 Jan 2005 00:20:44 +0100 Organization: None Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1104880924 27391 80.91.229.6 (4 Jan 2005 23:22:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 4 Jan 2005 23:22:04 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 05 00:21:48 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Clxzn-0003RO-00 for ; Wed, 05 Jan 2005 00:21:47 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1ClyB0-0001Dv-Uj for ged-emacs-devel@m.gmane.org; Tue, 04 Jan 2005 18:33:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1ClyAr-0001DV-SJ for emacs-devel@gnu.org; Tue, 04 Jan 2005 18:33:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1ClyAq-0001Cy-S2 for emacs-devel@gnu.org; Tue, 04 Jan 2005 18:33:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1ClyAq-0001Co-Oj for emacs-devel@gnu.org; Tue, 04 Jan 2005 18:33:12 -0500 Original-Received: from [80.91.229.2] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Clxyj-0006cM-Va for emacs-devel@gnu.org; Tue, 04 Jan 2005 18:20:42 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1Clxyj-0005wg-00 for ; Wed, 05 Jan 2005 00:20:41 +0100 Original-Received: from 123-233.242.81.adsl.skynet.be ([81.242.233.123]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 05 Jan 2005 00:20:41 +0100 Original-Received: from darkman_spam by 123-233.242.81.adsl.skynet.be with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 05 Jan 2005 00:20:41 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 37 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 123-233.242.81.adsl.skynet.be User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (windows-nt) Cancel-Lock: sha1:s8BA863PSFFOoPACcgtnHG+ErdU= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:31850 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:31850 Hello One of the patches I had when working on Ediff is this one: *** ediff-diff.el.old Thu Dec 23 07:01:56 2004 --- ediff-diff.el Thu Dec 30 08:24:14 2004 *************** *** 1338,1343 **** --- 1338,1350 ---- (append ediff-cmp-options (list f1 f2))))) (and (numberp res) (eq res 0)))) + (defun ediff-same-file-contents-3 (f1 f2 &optional f3) + "Return t if F1, F2 and F3 (if applicable) have identical contents." + (and (ediff-same-file-contents file1 file2) + (or (null file3) + (and (ediff-same-file-contents file1 file3) + (ediff-same-file-contents file2 file3))))) + ;;; Local Variables: ;;; eval: (put 'ediff-defvar-local 'lisp-indent-hook 'defun) You can see it ends by a incomplete local variables list. When I open it, I have the error: File local-variables error: (error "Local variables list is not properly terminated") I think that these lists doesn't have to be processed for such files, it isn't? However, I guess a bootsrap issue: local variables have to be processed to know the major mode, and how know to discard this processing without knowing the major mode? Is the current behaviour a bug or a feature? --drkm