From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Glenn Morris <rgm@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH 2/2] response handlers needed for SASL PLAIN authentication
Date: Thu, 19 Apr 2012 13:01:37 -0400
Message-ID: <whd373zmdq.fsf@fencepost.gnu.org>
References: <87ty3ae7s1.fsf@geneva.hpsy.me> <87obtie7lp.fsf@geneva.hpsy.me>
	<87y5psqqy4.fsf@geneva.hpsy.me>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: dough.gmane.org 1334854914 8595 80.91.229.3 (19 Apr 2012 17:01:54 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Thu, 19 Apr 2012 17:01:54 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Joseph Gay <ysph@psy.ai>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 19 19:01:52 2012
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1SKujw-0000LP-0Z
	for ged-emacs-devel@m.gmane.org; Thu, 19 Apr 2012 19:01:52 +0200
Original-Received: from localhost ([::1]:40232 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1SKujv-0003Ti-BF
	for ged-emacs-devel@m.gmane.org; Thu, 19 Apr 2012 13:01:51 -0400
Original-Received: from eggs.gnu.org ([208.118.235.92]:41729)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1SKujr-0003SZ-Nz
	for emacs-devel@gnu.org; Thu, 19 Apr 2012 13:01:48 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rgm@gnu.org>) id 1SKujj-0003LV-Sp
	for emacs-devel@gnu.org; Thu, 19 Apr 2012 13:01:47 -0400
Original-Received: from fencepost.gnu.org ([208.118.235.10]:39758)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1SKujj-0003LI-Q0
	for emacs-devel@gnu.org; Thu, 19 Apr 2012 13:01:39 -0400
Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71)
	(envelope-from <rgm@gnu.org>)
	id 1SKujh-0005G5-UA; Thu, 19 Apr 2012 13:01:37 -0400
X-Spook: insurgency MP5K-SD SDI encryption Geraldton top secret
X-Ran: `1ilG/SYN8wA2kBGVQgQ2pyB["p}fx%-xz{o-s,Op<se$c!bNZ+Y,>d~?8Um]bBW$<]EE#
X-Hue: yellow
X-Attribution: GM
In-Reply-To: <87y5psqqy4.fsf@geneva.hpsy.me> (Joseph Gay's message of "Wed, 18
	Apr 2012 23:35:31 -0500")
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 208.118.235.10
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:149823
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/149823>

Joseph Gay wrote:

> +;; Copyright (C) 2012 Free Software Foundation, Inc.

Please don't write this unless you have completed a copyright
assignment. Just use your name.

> +;; This file is part of GNU Emacs.

Again, not true yet.

> +(defvar erc-sasl-use-sasl t
> +  "Set to nil to disable SASL auth")
> +
> +(defvar erc-sasl-server-regexp-list '()
> +  "List of regexps matching server host names for which sasl
> +  should be used")

These should be defcustoms. Also, the first line of any doc string
should be a complete sentence, with a full-stop at the end.