From: Glenn Morris <rgm@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Mark Oteiza <mvoteiza@udel.edu>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument
Date: Mon, 24 Jul 2017 12:56:06 -0400 [thread overview]
Message-ID: <wco9s9zsd5.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwva83tucr2.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Mon, 24 Jul 2017 10:33:42 -0400")
Stefan Monnier wrote:
>> ;;;###autoload
>> +(defun turn-on-display-line-numbers-mode ()
>> + "Turn on `display-line-numbers-mode'."
>> + (unless (or (minibufferp)
>> + ;; taken from linum.el
>> + (and (daemonp) (null (frame-parameter nil 'client))))
>> + (display-line-numbers-mode)))
>
> Could you make it use the "display-line-numbers-" prefix?
>
>
> Stefan "who'd also use a ¨--" since it's unlikely to be useful
> outside of the package"
And then it doesn't need to be autoloaded.
next prev parent reply other threads:[~2017-07-24 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170723194435.31877.401@vcs0.savannah.gnu.org>
[not found] ` <20170723194436.81A9D20DDA@vcs0.savannah.gnu.org>
2017-07-24 14:33 ` [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument Stefan Monnier
2017-07-24 16:56 ` Glenn Morris [this message]
2017-07-25 0:25 ` Mark Oteiza
2017-07-25 0:31 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wco9s9zsd5.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=mvoteiza@udel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).