From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Benjamin Rutt Newsgroups: gmane.emacs.devel Subject: Re: [patch] add interactive browse of revisions from vc *Annotate* buffers Date: Mon, 12 Jan 2004 12:20:52 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1073929955 14609 80.91.224.253 (12 Jan 2004 17:52:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 12 Jan 2004 17:52:35 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Jan 12 18:52:24 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ag6Eh-00039Y-00 for ; Mon, 12 Jan 2004 18:52:23 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ag6Eg-0000ZA-00 for ; Mon, 12 Jan 2004 18:52:23 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Ag6id-0005ZP-Gx for emacs-devel@quimby.gnus.org; Mon, 12 Jan 2004 13:23:19 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1Ag6iN-0005YC-2c for emacs-devel@gnu.org; Mon, 12 Jan 2004 13:23:03 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Ag6hp-0005Le-Tx for emacs-devel@gnu.org; Mon, 12 Jan 2004 13:23:01 -0500 Original-Received: from [164.107.123.5] (helo=cis.ohio-state.edu) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Ag6hp-0005KI-5K for emacs-devel@gnu.org; Mon, 12 Jan 2004 13:22:29 -0500 Original-Received: from mu.cis.ohio-state.edu (daemon@mu.cis.ohio-state.edu [164.107.112.41]) by cis.ohio-state.edu (8.11.6p2-20030924/8.11.6) with ESMTP id i0CHKqP28705; Mon, 12 Jan 2004 12:20:52 -0500 (EST) Original-Received: (from rutt@localhost) by mu.cis.ohio-state.edu (8.11.6p2-20030924/8.11.6) id i0CHKqU22218; Mon, 12 Jan 2004 12:20:52 -0500 (EST) X-Authentication-Warning: mu.cis.ohio-state.edu: rutt set sender to rutt.4@osu.edu using -f Original-To: storm@cua.dk (Kim F. Storm) Mail-Followup-To: storm@cua.dk (Kim F. Storm), emacs-devel@gnu.org In-Reply-To: (Kim F. Storm's message of "12 Jan 2004 18:11:37 +0100") User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (usg-unix-v) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19146 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19146 storm@cua.dk (Kim F. Storm) writes: > Benjamin Rutt writes: > >> and let's say the cursor is on the line where revision 1.3 is at. Are >> you saying you'd like a function to warp you instantly back to 1.3, >> instead of having to go back iteratively through 1.23, 1.22, 1.21, >> ..., 1.4, 1.3? If this isn't your idea, could you give an example of >> what your idea is? Thanks, > > Actually, I was thinking about going back to 1.2 -- i.e. to see when > the _previous_ change to that line happened (unless it's new in 1.3 > of course). I think that's certainly possible. What I'm thinking now is the following: if there's a prefix argument to the function vc-annotate-prev-version, alter behavior in the following manner: 1) if the prefix argument is numeric, go backwards that many versions if possible 2) otherwise, go to the revision prior to the revision of the current line (what Kim Storm was asking for). The "revision of the current line" extractor will have to be made generic through a backend, since there's no guarantee that the *Annotate* buffer will have the version number at the beginning of the line followed by whitespace, although that's true for CVS at the moment. As far as your comment "(unless it's new in 1.3 of course)" above, I think I'll just leave it up to the user recognize when that happens, and trust them to go forwards in time one revision at that time. I also think I'd like to add a keybinding such that pressing RET in any of the *Annotate* buffer lines which contain a revision number simply does "annotate the revision mentioned on this line". -- Benjamin