From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Benjamin Rutt Newsgroups: gmane.emacs.devel Subject: Re: Build break: GNU Emacs 21.3.50 (CVS) HEAD Date: Wed, 25 Jun 2003 18:56:24 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20030624113955.9172B7111A@smtp.us2.messagingengine.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1056582578 21393 80.91.224.249 (25 Jun 2003 23:09:38 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 25 Jun 2003 23:09:38 +0000 (UTC) Cc: Emacs Devel Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Jun 26 01:09:37 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19VJOS-0005Yt-00 for ; Thu, 26 Jun 2003 01:09:36 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19VJSh-0002pQ-00 for ; Thu, 26 Jun 2003 01:13:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19VJMZ-00065t-Pi for emacs-devel@quimby.gnus.org; Wed, 25 Jun 2003 19:07:39 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19VJFq-0005MP-4x for emacs-devel@gnu.org; Wed, 25 Jun 2003 19:00:42 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19VJEg-0005Ah-Nn for emacs-devel@gnu.org; Wed, 25 Jun 2003 18:59:34 -0400 Original-Received: from mail.cis.ohio-state.edu ([164.107.115.5] helo=cis.ohio-state.edu) by monty-python.gnu.org with esmtp (Exim 4.20) id 19VJBi-0004df-FS; Wed, 25 Jun 2003 18:56:26 -0400 Original-Received: from gamma.cis.ohio-state.edu (daemon@gamma.cis.ohio-state.edu [164.107.112.13]) by cis.ohio-state.edu (8.11.6p2/8.11.6) with ESMTP id h5PMuO003449; Wed, 25 Jun 2003 18:56:24 -0400 (EDT) Original-Received: (from rutt@localhost) by gamma.cis.ohio-state.edu (8.11.6p2/8.11.6) id h5PMuOl24088; Wed, 25 Jun 2003 18:56:24 -0400 (EDT) X-Authentication-Warning: gamma.cis.ohio-state.edu: rutt set sender to rutt@cis.ohio-state.edu using -f Original-To: "Dhruva Krishnamurthy" User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3.50 (usg-unix-v) Original-cc: fx@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:15255 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:15255 "Dhruva Krishnamurthy" writes: > There is a compilation error in GNU Emacs 21.3.50 (CVS) src/strftime.c > (extra args in call to my_strftime() at #1491) on W2K using MinGW32-GCC > 3.2.3 I am seeing this as well right now, on the Solaris 2.8 sparc platform. Here is the exact error message: gcc -c -Demacs -DHAVE_CONFIG_H -DUSE_LUCID -I. -I/tmp/rutt/emacs/src -I/usr/openwin/include -I/usr/dt/include -g -O2 strftime.c strftime.c: In function `emacs_strftimeu': strftime.c:1491: too many arguments to function `_strftime_copytm' make[1]: *** [strftime.o] Error 1 make[1]: Leaving directory `/tmp/rutt/emacs/src' make: *** [bootstrap] Error 2 The following patch gets rid of the compile error, but is the fix the right one? Thanks for any feedback. Index: strftime.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/strftime.c,v retrieving revision 1.29 diff -c -r1.29 strftime.c *** strftime.c 24 Jun 2003 09:42:14 -0000 1.29 --- strftime.c 25 Jun 2003 22:52:56 -0000 *************** *** 1488,1493 **** const struct tm *tp; int ut; { ! return my_strftime (s, maxsize, format, tp, ut, 0); } #endif --- 1488,1493 ---- const struct tm *tp; int ut; { ! return my_strftime (s, maxsize, format, tp); } #endif -- Benjamin