Re: Build break: GNU Emacs 21.3.50 (CVS) HEAD

[Benjamin Rutt <rutt+news@cis.ohio-state.edu>]

"Dhruva Krishnamurthy" <seagull@fastmail.fm> writes:

>  There is a compilation error in GNU Emacs 21.3.50 (CVS) src/strftime.c
>  (extra args in call to my_strftime() at #1491) on W2K using MinGW32-GCC
>  3.2.3

I am seeing this as well right now, on the Solaris 2.8 sparc
platform.  Here is the exact error message:

    gcc -c  -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/rutt/emacs/src -I/usr/openwin/include -I/usr/dt/include -g -O2 strftime.c
    strftime.c: In function `emacs_strftimeu':
    strftime.c:1491: too many arguments to function `_strftime_copytm'
    make[1]: *** [strftime.o] Error 1
    make[1]: Leaving directory `/tmp/rutt/emacs/src'
    make: *** [bootstrap] Error 2

The following patch gets rid of the compile error, but is the fix the
right one?  Thanks for any feedback.

Index: strftime.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/strftime.c,v
retrieving revision 1.29
diff -c -r1.29 strftime.c
*** strftime.c  24 Jun 2003 09:42:14 -0000      1.29
--- strftime.c  25 Jun 2003 22:52:56 -0000
***************
*** 1488,1493 ****
        const struct tm *tp;
        int ut;
  {
!   return my_strftime (s, maxsize, format, tp, ut, 0);
  }
  #endif
--- 1488,1493 ----
        const struct tm *tp;
        int ut;
  {
!   return my_strftime (s, maxsize, format, tp);
  }
  #endif


-- 
Benjamin