From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Benjamin Rutt Newsgroups: gmane.emacs.devel Subject: Re: [patch] add interactive browse of revisions from vc *Annotate* buffers Date: Tue, 20 Jan 2004 17:28:42 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <1073937837.2822.180.camel@localhost> <1074519239.10692.24.camel@localhost> <1074621500.13077.151.camel@localhost> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1074655184 29995 80.91.224.253 (21 Jan 2004 03:19:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 21 Jan 2004 03:19:44 +0000 (UTC) Cc: Andre Spiegel , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Jan 21 04:19:38 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Aj8u2-0000pB-00 for ; Wed, 21 Jan 2004 04:19:38 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Aj8u1-0002Sb-00 for ; Wed, 21 Jan 2004 04:19:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Aj7te-0002WO-6U for emacs-devel@quimby.gnus.org; Tue, 20 Jan 2004 21:15:10 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1Aj6cP-0003r2-6o for emacs-devel@gnu.org; Tue, 20 Jan 2004 19:53:17 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Aj4oh-0005YZ-50 for emacs-devel@gnu.org; Tue, 20 Jan 2004 17:58:22 -0500 Original-Received: from [164.107.123.5] (helo=cis.ohio-state.edu) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Aj4MZ-0001AC-2X; Tue, 20 Jan 2004 17:28:47 -0500 Original-Received: from mu.cis.ohio-state.edu (daemon@mu.cis.ohio-state.edu [164.107.112.41]) by cis.ohio-state.edu (8.11.6p2-20030924/8.11.6) with ESMTP id i0KMSgP24474; Tue, 20 Jan 2004 17:28:42 -0500 (EST) Original-Received: (from rutt@localhost) by mu.cis.ohio-state.edu (8.11.6p2-20030924/8.11.6) id i0KMSgK27943; Tue, 20 Jan 2004 17:28:42 -0500 (EST) X-Authentication-Warning: mu.cis.ohio-state.edu: rutt set sender to rutt.4@osu.edu using -f Original-To: Stefan Monnier Mail-Followup-To: Stefan Monnier , Andre Spiegel , emacs-devel@gnu.org In-Reply-To: (Stefan Monnier's message of "20 Jan 2004 15:33:20 -0500") User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (usg-unix-v) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19374 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19374 Stefan Monnier writes: > I strongly expect that the problem is in the fact that you use view-mode as > parent even though it's not a major-mode. Thanks for the tip, you are correct; I guess define-derived-mode was somewhat misleading to me since it doesn't mention anywhere in 'C-h f define-derived-mode' that it only works for major modes. Andre, could you install the following tiny patch that fixes the problem? Index: lisp/vc.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v retrieving revision 1.362 diff -u -r1.362 vc.el --- lisp/vc.el 20 Jan 2004 17:39:09 -0000 1.362 +++ lisp/vc.el 20 Jan 2004 22:25:47 -0000 @@ -2830,7 +2830,7 @@ `vc-annotate-buffers'." (cdr (assoc buffer vc-annotate-buffers))) -(define-derived-mode vc-annotate-mode view-mode "Annotate" +(define-derived-mode vc-annotate-mode fundamental-mode "Annotate" "Major mode for output buffers of the `vc-annotate' command. You can use the mode-specific menu to alter the time-span of the used @@ -2839,6 +2839,7 @@ (set (make-local-variable 'truncate-lines) t) (set (make-local-variable 'font-lock-defaults) '(vc-annotate-font-lock-keywords t)) + (view-mode 1) (vc-annotate-add-menu)) (defun vc-annotate-display-default (&optional ratio) -- Benjamin