From: Benjamin Rutt <brutt+news@bloomington.in.us>
Cc: Andre Spiegel <spiegel@gnu.org>, emacs-devel@gnu.org
Subject: Re: [patch] add interactive browse of revisions from vc *Annotate* buffers
Date: Tue, 20 Jan 2004 17:28:42 -0500 [thread overview]
Message-ID: <wc3ptdemezp.fsf@mu.cis.ohio-state.edu> (raw)
In-Reply-To: <jwvektufjjy.fsf-monnier+emacs/devel@asado.iro.umontreal.ca> (Stefan Monnier's message of "20 Jan 2004 15:33:20 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I strongly expect that the problem is in the fact that you use view-mode as
> parent even though it's not a major-mode.
Thanks for the tip, you are correct; I guess define-derived-mode was
somewhat misleading to me since it doesn't mention anywhere in 'C-h f
define-derived-mode' that it only works for major modes.
Andre, could you install the following tiny patch that fixes the
problem?
Index: lisp/vc.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v
retrieving revision 1.362
diff -u -r1.362 vc.el
--- lisp/vc.el 20 Jan 2004 17:39:09 -0000 1.362
+++ lisp/vc.el 20 Jan 2004 22:25:47 -0000
@@ -2830,7 +2830,7 @@
`vc-annotate-buffers'."
(cdr (assoc buffer vc-annotate-buffers)))
-(define-derived-mode vc-annotate-mode view-mode "Annotate"
+(define-derived-mode vc-annotate-mode fundamental-mode "Annotate"
"Major mode for output buffers of the `vc-annotate' command.
You can use the mode-specific menu to alter the time-span of the used
@@ -2839,6 +2839,7 @@
(set (make-local-variable 'truncate-lines) t)
(set (make-local-variable 'font-lock-defaults)
'(vc-annotate-font-lock-keywords t))
+ (view-mode 1)
(vc-annotate-add-menu))
(defun vc-annotate-display-default (&optional ratio)
--
Benjamin
next prev parent reply other threads:[~2004-01-20 22:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-12 2:54 [patch] add interactive browse of revisions from vc *Annotate* buffers Benjamin Rutt
2004-01-12 5:30 ` Andre Spiegel
2004-01-12 11:06 ` Kim F. Storm
2004-01-12 13:58 ` Benjamin Rutt
2004-01-12 17:11 ` Kim F. Storm
2004-01-12 17:20 ` Benjamin Rutt
2004-01-12 20:09 ` Andre Spiegel
2004-01-12 20:35 ` Benjamin Rutt
2004-01-13 10:57 ` Kim F. Storm
2004-01-14 15:45 ` Richard Stallman
2004-01-14 21:55 ` Kim F. Storm
2004-01-15 19:58 ` Andre Spiegel
2004-01-16 10:40 ` Richard Stallman
2004-01-16 16:30 ` Kim F. Storm
2004-01-17 12:55 ` Richard Stallman
2004-01-17 21:34 ` Benjamin Rutt
2004-01-19 13:33 ` Andre Spiegel
2004-01-19 20:39 ` Kai Grossjohann
2004-01-19 20:54 ` Benjamin Rutt
2004-01-20 1:28 ` Kim F. Storm
2004-01-20 15:31 ` Richard Stallman
2004-01-21 11:26 ` Kim F. Storm
2004-01-21 14:15 ` Stefan Monnier
2004-01-21 16:39 ` Kim F. Storm
2004-01-21 18:38 ` Stefan Monnier
2004-01-22 22:06 ` Kim F. Storm
2004-01-22 23:39 ` Andre Spiegel
2004-01-23 1:54 ` Benjamin Rutt
2004-01-22 19:00 ` Richard Stallman
2004-01-23 2:02 ` Miles Bader
2004-02-07 2:06 ` Kim F. Storm
2004-01-20 18:11 ` Kevin Rodgers
2004-01-20 15:32 ` Stefan Monnier
2004-01-20 16:45 ` Benjamin Rutt
2004-01-20 18:26 ` Stefan Monnier
2004-01-20 20:10 ` Benjamin Rutt
2004-01-19 21:13 ` Benjamin Rutt
2004-01-20 17:58 ` Andre Spiegel
2004-01-20 20:05 ` Benjamin Rutt
2004-01-20 20:33 ` Stefan Monnier
2004-01-20 22:28 ` Benjamin Rutt [this message]
2004-01-22 23:20 ` Kevin Rodgers
2004-01-22 23:40 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wc3ptdemezp.fsf@mu.cis.ohio-state.edu \
--to=brutt+news@bloomington.in.us \
--cc=emacs-devel@gnu.org \
--cc=spiegel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).