From: Benjamin Rutt <brutt+news@bloomington.in.us>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] add interactive browse of revisions from vc *Annotate* buffers
Date: Thu, 22 Jan 2004 20:54:49 -0500 [thread overview]
Message-ID: <wc31xpro2dy.fsf@mu.cis.ohio-state.edu> (raw)
In-Reply-To: <1074814741.13077.214.camel@localhost> (Andre Spiegel's message of "Fri, 23 Jan 2004 00:39:01 +0100")
Andre Spiegel <spiegel@gnu.org> writes:
> On Thu, 2004-01-22 at 23:06, Kim F. Storm wrote:
>
>> I just committed the new code to CVS. This also means that there is now a
>> line-at-pos function which return the current line number.
>
> I've just changed vc.el to use line-at-pos instead of vc-current-line.
> Thanks.
Thank you for taking care of that for me. Could you also commit the
following bugfix to my code? The bug showed up when you have multiple
vc-annotate buffers open; I was using `make-local-variable'
improperly; that is, it wasn't being evaluated in the buffer that
actually needed the buffer-local variable (that being the annotate
buffer).
Thanks,
Benjamin Rutt
Index: vc.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v
retrieving revision 1.364
diff -c -r1.364 vc.el
*** vc.el 22 Jan 2004 23:34:33 -0000 1.364
--- vc.el 23 Jan 2004 01:53:05 -0000
***************
*** 2816,2824 ****
(defvar vc-annotate-parent-file nil)
(defvar vc-annotate-parent-rev nil)
(defvar vc-annotate-parent-display-mode nil)
- (make-local-variable 'vc-annotate-parent-file)
- (make-local-variable 'vc-annotate-parent-rev)
- (make-local-variable 'vc-annotate-parent-display-mode)
(defconst vc-annotate-font-lock-keywords
;; The fontification is done by vc-annotate-lines instead of font-lock.
--- 2816,2821 ----
***************
*** 3038,3046 ****
vc-annotate-version))
(save-excursion
(set-buffer temp-buffer-name)
! (setq vc-annotate-parent-file bfn)
! (setq vc-annotate-parent-rev vc-annotate-version)
! (setq vc-annotate-parent-display-mode vc-annotate-display-mode))
;; Don't use the temp-buffer-name until the buffer is created
;; (only after `with-output-to-temp-buffer'.)
--- 3035,3044 ----
vc-annotate-version))
(save-excursion
(set-buffer temp-buffer-name)
! (set (make-local-variable 'vc-annotate-parent-file) bfn)
! (set (make-local-variable 'vc-annotate-parent-rev) vc-annotate-version)
! (set (make-local-variable 'vc-annotate-parent-display-mode)
! vc-annotate-display-mode))
;; Don't use the temp-buffer-name until the buffer is created
;; (only after `with-output-to-temp-buffer'.)
Index: ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.5619
diff -c -r1.5619 ChangeLog
*** ChangeLog 22 Jan 2004 23:37:46 -0000 1.5619
--- ChangeLog 23 Jan 2004 01:53:05 -0000
***************
*** 1,3 ****
--- 1,8 ----
+ 2004-01-22 Benjamin Rutt <brutt@bloomington.in.us>
+
+ * vc.el (vc-annotate): Fix improper use of `make-local-variable'
+ at the top level of vc.el.
+
2004-01-23 Andre Spiegel <spiegel@gnu.org>
* vc.el (vc-current-line): Function removed. This is now done by
next prev parent reply other threads:[~2004-01-23 1:54 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-12 2:54 [patch] add interactive browse of revisions from vc *Annotate* buffers Benjamin Rutt
2004-01-12 5:30 ` Andre Spiegel
2004-01-12 11:06 ` Kim F. Storm
2004-01-12 13:58 ` Benjamin Rutt
2004-01-12 17:11 ` Kim F. Storm
2004-01-12 17:20 ` Benjamin Rutt
2004-01-12 20:09 ` Andre Spiegel
2004-01-12 20:35 ` Benjamin Rutt
2004-01-13 10:57 ` Kim F. Storm
2004-01-14 15:45 ` Richard Stallman
2004-01-14 21:55 ` Kim F. Storm
2004-01-15 19:58 ` Andre Spiegel
2004-01-16 10:40 ` Richard Stallman
2004-01-16 16:30 ` Kim F. Storm
2004-01-17 12:55 ` Richard Stallman
2004-01-17 21:34 ` Benjamin Rutt
2004-01-19 13:33 ` Andre Spiegel
2004-01-19 20:39 ` Kai Grossjohann
2004-01-19 20:54 ` Benjamin Rutt
2004-01-20 1:28 ` Kim F. Storm
2004-01-20 15:31 ` Richard Stallman
2004-01-21 11:26 ` Kim F. Storm
2004-01-21 14:15 ` Stefan Monnier
2004-01-21 16:39 ` Kim F. Storm
2004-01-21 18:38 ` Stefan Monnier
2004-01-22 22:06 ` Kim F. Storm
2004-01-22 23:39 ` Andre Spiegel
2004-01-23 1:54 ` Benjamin Rutt [this message]
2004-01-22 19:00 ` Richard Stallman
2004-01-23 2:02 ` Miles Bader
2004-02-07 2:06 ` Kim F. Storm
2004-01-20 18:11 ` Kevin Rodgers
2004-01-20 15:32 ` Stefan Monnier
2004-01-20 16:45 ` Benjamin Rutt
2004-01-20 18:26 ` Stefan Monnier
2004-01-20 20:10 ` Benjamin Rutt
2004-01-19 21:13 ` Benjamin Rutt
2004-01-20 17:58 ` Andre Spiegel
2004-01-20 20:05 ` Benjamin Rutt
2004-01-20 20:33 ` Stefan Monnier
2004-01-20 22:28 ` Benjamin Rutt
2004-01-22 23:20 ` Kevin Rodgers
2004-01-22 23:40 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wc31xpro2dy.fsf@mu.cis.ohio-state.edu \
--to=brutt+news@bloomington.in.us \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).