From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.devel Subject: Re: Merging bignum to master Date: Mon, 13 Aug 2018 10:06:45 +0200 Message-ID: References: <877ekwu1mn.fsf@tromey.com> <48742e8c-fffb-7fe0-bb12-2ce3dc171603@cs.ucla.edu> <837ekvlau2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1534147537 24682 195.159.176.226 (13 Aug 2018 08:05:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 13 Aug 2018 08:05:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eli Zaretskii , Paul Eggert , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 13 10:05:32 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fp7r2-0006ID-2w for ged-emacs-devel@m.gmane.org; Mon, 13 Aug 2018 10:05:32 +0200 Original-Received: from localhost ([::1]:38015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fp7t6-0005F5-Of for ged-emacs-devel@m.gmane.org; Mon, 13 Aug 2018 04:07:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fp7sQ-0005Ek-61 for emacs-devel@gnu.org; Mon, 13 Aug 2018 04:06:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fp7sO-00028C-VX for emacs-devel@gnu.org; Mon, 13 Aug 2018 04:06:58 -0400 Original-Received: from dev.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]:41139 helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fp7sL-00025x-5M; Mon, 13 Aug 2018 04:06:53 -0400 Original-Received: from a1i15 (host2092.kph.uni-mainz.de [134.93.134.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ulm) by smtp.gentoo.org (Postfix) with ESMTPSA id 0006F335C7F; Mon, 13 Aug 2018 08:06:48 +0000 (UTC) In-Reply-To: (Andreas Schwab's message of "Mon, 13 Aug 2018 09:51:41 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:470:ea4a:1:5054:ff:fec7:86e4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228469 Archived-At: >>>>> On Mon, 13 Aug 2018, Andreas Schwab wrote: > On Aug 12 2018, Paul Eggert wrote: >> The GNU coding standards say that --enable is supposed to be for adding >> user-level facilities, which this is not: the user-level behavior does not >> change. Conversely, the coding standards say that --with is appropriate >> for choosing to use a library like GMP. So --with-SOMETHING seems more >> appropriate here than --enable-SOMETHING. > The autoconf manual says about --enable: "They should only cause parts > of the program to be built rather than left out." The mini-gmp source > is a part of the sources, and --enable-mini-gmp enables the use of it. > --with is for external dependencies. The option also controls linking against the external libgmp, so it is not entirely about internal sources. Maybe it would be cleaner to call the option --with-gmp (and invert its logic), after all? It could still be enabled by default.