From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.devel Subject: Re: No support for ImageMagick 7 in emacs-26 Date: Mon, 26 Nov 2018 08:38:21 +0100 Message-ID: References: <83efb9jf7x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1543217830 17126 195.159.176.226 (26 Nov 2018 07:37:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Nov 2018 07:37:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 26 08:37:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRBS4-0004L1-LE for ged-emacs-devel@m.gmane.org; Mon, 26 Nov 2018 08:37:04 +0100 Original-Received: from localhost ([::1]:34519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRBUB-00061f-AM for ged-emacs-devel@m.gmane.org; Mon, 26 Nov 2018 02:39:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRBTY-00061O-VP for emacs-devel@gnu.org; Mon, 26 Nov 2018 02:38:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRBTY-00051t-1q for emacs-devel@gnu.org; Mon, 26 Nov 2018 02:38:36 -0500 Original-Received: from dev.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]:60085 helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRBTU-0004x1-IP; Mon, 26 Nov 2018 02:38:32 -0500 Original-Received: from a1i15 (host2092.kph.uni-mainz.de [134.93.134.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ulm) by smtp.gentoo.org (Postfix) with ESMTPSA id 7F837335D9C; Mon, 26 Nov 2018 07:38:28 +0000 (UTC) In-Reply-To: <83efb9jf7x.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Nov 2018 18:26:26 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:470:ea4a:1:5054:ff:fec7:86e4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231384 Archived-At: >>>>> On Sun, 25 Nov 2018, Eli Zaretskii wrote: >> From: Ulrich Mueller >> Date: Sun, 25 Nov 2018 09:26:56 +0100 >> >> Given that ImageMagick 7 was released in April 2016, wouldn't it make >> sense to support that version in the upcoming Emacs 26.2? >> >> AFAICS, commits 5729486951, bf1b147b55, 42ed35c68b, and 3cc42bb600 >> would have to be backported for that, which doesn't seem too >> intrusive. >> >> (In fact, Gentoo has a consolidated patch for 26.1: >> https://gitweb.gentoo.org/proj/emacs-patches.git/tree/emacs/26.1/02_all_imagemagick-7.patch) > It doesn't seem entirely trivial to me. ImageMagick caused quitea few > problems to Emacs, so at this point I can only accept patches to > support v7 on the release branch if the code used by v6.x is > completely unchanged. Sorry, but where do you see a change that could affect behaviour of v6.x? Effectively, the only code change in the consolidated patch is the following in image.c: - MagickRealType color_scale = 65535.0 / QuantumRange; + double quantum_range = QuantumRange; + MagickRealType color_scale = 65535.0 / quantum_range; Also, I noticed that configure will silently disable imagemagick if v6 is not found. This is o.k. for the default, but when I explicitly specify --with-imagemagick, then I would expect it to error out when it cannot enable the feature.