From: Ulrich Mueller <ulm@gentoo.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: No support for ImageMagick 7 in emacs-26
Date: Mon, 26 Nov 2018 08:38:21 +0100 [thread overview]
Message-ID: <w6glg5gcmqa.fsf@kph.uni-mainz.de> (raw)
In-Reply-To: <83efb9jf7x.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Nov 2018 18:26:26 +0200")
>>>>> On Sun, 25 Nov 2018, Eli Zaretskii wrote:
>> From: Ulrich Mueller <ulm@gentoo.org>
>> Date: Sun, 25 Nov 2018 09:26:56 +0100
>>
>> Given that ImageMagick 7 was released in April 2016, wouldn't it make
>> sense to support that version in the upcoming Emacs 26.2?
>>
>> AFAICS, commits 5729486951, bf1b147b55, 42ed35c68b, and 3cc42bb600
>> would have to be backported for that, which doesn't seem too
>> intrusive.
>>
>> (In fact, Gentoo has a consolidated patch for 26.1:
>> https://gitweb.gentoo.org/proj/emacs-patches.git/tree/emacs/26.1/02_all_imagemagick-7.patch)
> It doesn't seem entirely trivial to me. ImageMagick caused quitea few
> problems to Emacs, so at this point I can only accept patches to
> support v7 on the release branch if the code used by v6.x is
> completely unchanged.
Sorry, but where do you see a change that could affect behaviour of
v6.x? Effectively, the only code change in the consolidated patch is the
following in image.c:
- MagickRealType color_scale = 65535.0 / QuantumRange;
+ double quantum_range = QuantumRange;
+ MagickRealType color_scale = 65535.0 / quantum_range;
Also, I noticed that configure will silently disable imagemagick if v6
is not found. This is o.k. for the default, but when I explicitly
specify --with-imagemagick, then I would expect it to error out when it
cannot enable the feature.
next prev parent reply other threads:[~2018-11-26 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 8:26 No support for ImageMagick 7 in emacs-26 Ulrich Mueller
2018-11-25 16:26 ` Eli Zaretskii
2018-11-26 7:38 ` Ulrich Mueller [this message]
2018-11-26 17:38 ` Eli Zaretskii
2018-11-26 22:00 ` Ulrich Mueller
2018-11-26 22:07 ` Andreas Schwab
2018-11-27 5:48 ` Eli Zaretskii
2018-11-27 1:38 ` Paul Eggert
2018-11-27 6:14 ` Eli Zaretskii
2018-11-27 16:35 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w6glg5gcmqa.fsf@kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).