From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Glenn Morris <rgm@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH v2] POSIX ACL support
Date: Tue, 04 Dec 2012 21:28:04 -0500
Message-ID: <w2vcch1bd7.fsf@fencepost.gnu.org>
References: <87zk1wxlto.fsf@silenus.orebokech.com>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1354674498 31981 80.91.229.3 (5 Dec 2012 02:28:18 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Wed, 5 Dec 2012 02:28:18 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Romain Francoise <romain@orebokech.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 05 03:28:30 2012
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1Tg4io-0002T2-N2
	for ged-emacs-devel@m.gmane.org; Wed, 05 Dec 2012 03:28:26 +0100
Original-Received: from localhost ([::1]:41268 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1Tg4ic-0006qT-Rb
	for ged-emacs-devel@m.gmane.org; Tue, 04 Dec 2012 21:28:14 -0500
Original-Received: from eggs.gnu.org ([208.118.235.92]:52927)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1Tg4iZ-0006oQ-RS
	for emacs-devel@gnu.org; Tue, 04 Dec 2012 21:28:12 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rgm@gnu.org>) id 1Tg4iY-0007Rq-Sx
	for emacs-devel@gnu.org; Tue, 04 Dec 2012 21:28:11 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47519)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1Tg4iY-0007Rm-Pf
	for emacs-devel@gnu.org; Tue, 04 Dec 2012 21:28:10 -0500
Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71)
	(envelope-from <rgm@gnu.org>)
	id 1Tg4iS-00054Y-Lk; Tue, 04 Dec 2012 21:28:05 -0500
X-Spook: Dateline 22nd SAS cypherpunk militia illuminati AMEMB
X-Ran: 3FxO@_~_X3[&GP_Jc].:@_T|fav9It3{1SgjhHjKVsrlvF"!}PBngG\$~a&01'xEZ\3(bL
X-Hue: white
X-Attribution: GM
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
	(bad octet value).
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:155277
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/155277>

Romain Francoise wrote:

> +interface.  For the function @code{set-file-acl}, see @ref{Changing
> +Files}.

I'd use:

 For the function @code{set-file-acl}, @pxref{Changing Files}.

> +The return value is a string containing the textual representation of
> +the ACL entries.

Maybe give an example?

Apart from those trivial comments, just needs a NEWS entry.
Otherwise looks good to me...