From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Wed, 08 Aug 2018 17:35:31 +0100 Message-ID: References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> <87ftzrknyg.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533746068 26359 195.159.176.226 (8 Aug 2018 16:34:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2018 16:34:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 08 18:34:24 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnRPj-0006jh-Gw for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2018 18:34:23 +0200 Original-Received: from localhost ([::1]:44669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnRRp-0004KL-TF for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2018 12:36:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnRR2-0004I0-Hj for emacs-devel@gnu.org; Wed, 08 Aug 2018 12:35:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnRQy-0007iX-Iq for emacs-devel@gnu.org; Wed, 08 Aug 2018 12:35:44 -0400 Original-Received: from [195.159.176.226] (port=53127 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fnRQy-0007hn-3X for emacs-devel@gnu.org; Wed, 08 Aug 2018 12:35:40 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fnROp-0005cx-7w for emacs-devel@gnu.org; Wed, 08 Aug 2018 18:33:27 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 29 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:C3M2zU2u5OAoA8yQ6YyLNyDlUo4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228311 Archived-At: On Mon 06 Aug 2018, Tom Tromey wrote: > As far as I know the branch is ready. I have two uncommitted patches: > one for dumping (just sent) and one to use mpz_import (that I can't > test). The second one seems like a minor improvement and could probably > be dropped. Have you run "make check" on the bignum branch ? I see various test failures (many of which are also failures on master), and three crashes: 1) A crash in the json tests This is bug#32381, fixed on master in commit 3eac378c96. 2) An eassert in make_bignum_str called from string_to_number. This appears to be caused by differences in the syntax accepted by emacs lisp and by mpz_set_str. To reproduce: ELISP> (format "+%S" (- most-negative-fixnum)) "+2305843009213693952" ELISP> (string-to-number "+2305843009213693952") ### crash ### It also appears that make_bignum_str in alloc.c is only used in string_to_number, and so should be open coded in its caller. 3) Another crash which I have not yet had time to analyse with gdb. AndyM