From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Fri, 10 Aug 2018 12:39:33 +0100 Message-ID: References: <87o9fbbw1t.fsf@tromey.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> <87ftzrknyg.fsf@tromey.com> <87zhxwig5k.fsf@tromey.com> <86lg9gl7vy.fsf@gmail.com> <87tvo4i9em.fsf@tromey.com> <86k1ozl0yd.fsf@gmail.com> <83in4iojva.fsf@gnu.org> <86bmaasm39.fsf@gmail.com> <83a7puo8oq.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533901073 13388 195.159.176.226 (10 Aug 2018 11:37:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Aug 2018 11:37:53 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 10 13:37:49 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fo5jl-0003Gq-O5 for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2018 13:37:45 +0200 Original-Received: from localhost ([::1]:55558 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo5lq-0005N5-99 for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2018 07:39:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fo5lj-0005CV-LK for emacs-devel@gnu.org; Fri, 10 Aug 2018 07:39:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fo5le-0005YQ-Ng for emacs-devel@gnu.org; Fri, 10 Aug 2018 07:39:47 -0400 Original-Received: from [195.159.176.226] (port=58905 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fo5le-0005XX-Eg for emacs-devel@gnu.org; Fri, 10 Aug 2018 07:39:42 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fo5jV-00031s-8I for emacs-devel@gnu.org; Fri, 10 Aug 2018 13:37:29 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 54 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:8O8uQEH93jTQ0RxG9HZzKBgRaJc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228362 Archived-At: On Fri 10 Aug 2018, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Fri, 10 Aug 2018 08:43:38 +0100 >> >> Building the GMP library builds *different* gmp.h headers when building >> for static library vs. a shared library. >> >> The only difference in the headers preduced by the static libary and >> shared libary builds is the hunk shown above. The shared library version >> (the second hunk above) ensures that APIs get a __dllimport__ >> decoration for APIs on Windows, for linking to the shared library. >> >> The MSYS2 GMP package includes a single gmp.h header for the static >> library build, installed as "c:/msys64/mingw64/include/gmp.h". > > Yes, I know. I would like to try to use the gmp.h header without > changes, if possible, since that makes it easier for others to build > Emacs. Agreed - modifying the header is about problem diagnosis, not a long term solution. >> Emacs currently links against the shared library on MSYS2 64bit, and has >> a dependency on "c:/msys64/mingw64/bin/libgmp-10.dll". > > You mean, on the bignum branch or on master/emacs-26? If the latter, This entire thread is about the bignum branch. GMP has never been linked in on master. Why would you think otherwise ? Of course this is about the bignum branch. > is the dependency on libgmp recorded in the binary, or do you see it > in a running session? In either case, is the dependency direct in > Emacs or indirect via some other library, and if so, which library > causes the dependency? I used the MSYS2 version of cygcheck to report the dependencies, and also the Dependency Walker tool. Both show libgmp-10.dll as a direct dependency of emacs.exe. >> Using the gmp.h header without __dllimport__ API decorations probably >> results in incorrect runtime linking to the DLL. > > That's what I don't understand, yet. The only thing I changed was the dllimport decorations, and that changed the behaviour from a crash to working properly. It is possible that some other change in output after recompilation fixed the bad behaviour, but improper runtime linking is a reasonable cause for this problem. Further diagnosis from someone more expert than me is required to confirm if that is the cause. AndyM