From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Wed, 18 Jul 2018 12:14:03 +0100 Message-ID: References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <83efg4a6ie.fsf@gnu.org> <41221ccf-0c1a-c7e6-2204-e3f9056f7eb5@cs.ucla.edu> <838t6c9wx5.fsf@gnu.org> <53ba128d-7888-e15a-c4a2-1d7a65f51345@cs.ucla.edu> <83wotu7fcj.fsf@gnu.org> <83k1pt7q1e.fsf@gnu.org> <83h8kx7oeu.fsf@gnu.org> <83fu0h7nr6.fsf@gnu.org> <83d0vl7kg2.fsf@gnu.org> <4bc2a6ba-bc73-c4a9-f7a6-20303955bc7f@cs.ucla.edu> <838t696zb2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531912519 4382 195.159.176.226 (18 Jul 2018 11:15:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Jul 2018 11:15:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 18 13:15:15 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffkQM-00012M-1K for ged-emacs-devel@m.gmane.org; Wed, 18 Jul 2018 13:15:14 +0200 Original-Received: from localhost ([::1]:35950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffkSS-0003fJ-M7 for ged-emacs-devel@m.gmane.org; Wed, 18 Jul 2018 07:17:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffkSM-0003fE-Rh for emacs-devel@gnu.org; Wed, 18 Jul 2018 07:17:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffkSJ-000122-Nk for emacs-devel@gnu.org; Wed, 18 Jul 2018 07:17:18 -0400 Original-Received: from [195.159.176.226] (port=37286 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffkSJ-00011d-G3 for emacs-devel@gnu.org; Wed, 18 Jul 2018 07:17:15 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1ffkQA-0000q7-JF for emacs-devel@gnu.org; Wed, 18 Jul 2018 13:15:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:8ifuo2JjffWEGdulm1qis8bdHV4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227535 Archived-At: On Wed 18 Jul 2018, Paul Eggert wrote: > Stefan Monnier wrote: >> I recently posted a patch which makes EQ behave like `eql` attached. >> I just tried to see its impact on the ELisp compilation time >> (i.e. I did `rm **/*.elc; make`). > > I tried to reproduce this on my machine, and ran into some trouble (the code > had warnings that caused compilation to fail). Although your patch is > evidently intended only as a quick benchmark and not as an actual change, I > worry that the benchmark isn't realistic enough, as some usage of EQ in C code > will need to change to Feql or equivalent. Also, the C code will need to > change how hashing works since XHASH etc. must be consistent with eq. > > Looking into this a bit more, I discovered that eql currently operates > incorrectly on NaNs, as it's inconsistent with how hash tables work. I > installed the attached patch into master to fix that. Your added testcase has: +;; Test that equality predicates work correctly on NaNs when combined +;; with hash tables based on those predicates. This was not the case +;; for eql in Emacs 26. Shouldn't something similar be added to NEWS ? AndyM