From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Testing native image scaling Date: Thu, 28 Mar 2019 18:06:17 +0000 Message-ID: References: <83fttpat8p.fsf@gnu.org> <20190119214543.GA13967@breton.holly.idiocy.org> <834la3b9hd.fsf@gnu.org> <838sx0kzw9.fsf@gnu.org> <83va03j8c0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="226010"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 28 19:09:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9ZSn-000whC-MC for ged-emacs-devel@m.gmane.org; Thu, 28 Mar 2019 19:09:17 +0100 Original-Received: from localhost ([127.0.0.1]:40048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9ZSm-000679-Jk for ged-emacs-devel@m.gmane.org; Thu, 28 Mar 2019 14:09:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9ZRl-00064t-HY for emacs-devel@gnu.org; Thu, 28 Mar 2019 14:08:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9ZQ3-0003nt-MM for emacs-devel@gnu.org; Thu, 28 Mar 2019 14:06:28 -0400 Original-Received: from [195.159.176.226] (port=33224 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9ZQ3-0003hH-Dq for emacs-devel@gnu.org; Thu, 28 Mar 2019 14:06:27 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h9ZQ0-000t8b-5p for emacs-devel@gnu.org; Thu, 28 Mar 2019 19:06:24 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:WK1ZBuRw5jsoLtiIme4zA84jc5U= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234804 Archived-At: On Thu 28 Mar 2019, Eli Zaretskii wrote: >> Date: Thu, 28 Mar 2019 11:26:46 +0900 >> From: YAMAMOTO Mitsuharu >> >> > > It seems to work, but maybe I don't know what and how to check. Can >> > > you show what I should expect to see with and without the :scale >> > > attribute, in "emacs -Q"? >> > > >> > > Thanks. >> > >> > I would expect a sliced image to be composed of a grid of tiled images >> > instead of a single image, but to have the same visual appearance as the >> > original image. The w32 code does not get this right. >> >> Thanks for the screenshot. That's what I suspected from the code in >> w32term.c and the documentation of StretchBlt. Below is the >> screenshot on Xrender, and it should be the expected result. The >> cursor is at the last row and the last column of the sliced image. > > Thanks, I think I fixed this now. Confirmed. Should the and bindings for `image-decrease-size' and `image-increase-size' be adjusted to handle sliced images ? Also, in w32 builds of emacs-26 'M-X image-rotate' on a (non-sliced) image logs a message: "image--get-imagemagick-and-warn: Cannot rescale images without ImageMagick support", whereas on master it does nothing. Is image rotation expected to work on Windows ? AndyM