From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 36dc39b: * lisp/gnus/gnus-sum.el: Prepare for lexical-binding Date: Tue, 09 Apr 2019 16:11:17 +0100 Message-ID: References: <20190408204943.16965.86497@vcs0.savannah.gnu.org> <20190408204944.85B29209A7@vcs0.savannah.gnu.org> <87r2acayg5.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="117364"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 17:13:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDsR8-000UR2-Eu for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 17:13:22 +0200 Original-Received: from localhost ([127.0.0.1]:43110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDsR7-00025q-FU for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 11:13:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDsPN-0001OC-IL for emacs-devel@gnu.org; Tue, 09 Apr 2019 11:11:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDsPM-0005Y8-H2 for emacs-devel@gnu.org; Tue, 09 Apr 2019 11:11:33 -0400 Original-Received: from [195.159.176.226] (port=39410 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDsPM-0005XG-7k for emacs-devel@gnu.org; Tue, 09 Apr 2019 11:11:32 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hDsPG-000S7O-Kp for emacs-devel@gnu.org; Tue, 09 Apr 2019 17:11:26 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:wab/VCTp77MRlHLJtpD/0kI+lPg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235166 Archived-At: On Mon 08 Apr 2019, Stefan Monnier wrote: >> The dolist and while implementations aren't equivalent here (see my own >> attempt at this[1] and the resulting bug[2]), so I took the liberty of >> re-applying Yamaoka-san's fix[3] on top of your changes in the meantime. > > Duh, indeed, thanks, > > > Stefan As this problem has now bitten twice, perhaps it merits a comment in the code to prevent it being "fixed" again... AndyM