From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Testing native image scaling Date: Thu, 28 Mar 2019 19:29:45 +0000 Message-ID: References: <83fttpat8p.fsf@gnu.org> <20190119214543.GA13967@breton.holly.idiocy.org> <834la3b9hd.fsf@gnu.org> <838sx0kzw9.fsf@gnu.org> <83va03j8c0.fsf@gnu.org> <83k1gikgjy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="90125"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 28 20:40:18 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9asr-000NKw-R8 for ged-emacs-devel@m.gmane.org; Thu, 28 Mar 2019 20:40:17 +0100 Original-Received: from localhost ([127.0.0.1]:41185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9asq-0000eh-Mx for ged-emacs-devel@m.gmane.org; Thu, 28 Mar 2019 15:40:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9aqA-00074x-Sc for emacs-devel@gnu.org; Thu, 28 Mar 2019 15:37:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9aiq-0002zX-Jl for emacs-devel@gnu.org; Thu, 28 Mar 2019 15:29:57 -0400 Original-Received: from [195.159.176.226] (port=59988 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9aiq-0002z8-BO for emacs-devel@gnu.org; Thu, 28 Mar 2019 15:29:56 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h9aim-000B0T-2P for emacs-devel@gnu.org; Thu, 28 Mar 2019 20:29:52 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:ogkGuku9JHVEoRWm5YjForMBgcg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234807 Archived-At: On Thu 28 Mar 2019, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Thu, 28 Mar 2019 18:06:17 +0000 >> >> Should the and bindings for `image-decrease-size' >> and `image-increase-size' be adjusted to handle sliced images ? > > It would be nice, yes. A little experimentation shows that changing `image--get-image' as below seems to be sufficient to work for normal and sliced images: (defun image--get-image () "Return the image at point." (let ((image (get-char-property (point) 'display)) result) (when (consp image) (if (eq (car image) 'image) (setq result image) (dolist (x image) (if (eq (car-safe x) 'image) (setq result x))))) (when (null result) (error "No image under point")) result)) >> Is image rotation expected to work on Windows ? > > Not without ImageMagick, no. (And not only on Windows, AFAIK.) ok, but if ImageMagick is not available it used to complain and now does not. It should still report the same error message rather than failing silently. AndyM