* Minor bug in verilog-mode.el
@ 2012-04-21 16:32 Andy Moreton
2012-04-21 17:12 ` Juanma Barranquero
0 siblings, 1 reply; 6+ messages in thread
From: Andy Moreton @ 2012-04-21 16:32 UTC (permalink / raw)
To: emacs-devel
Hi,
In verilog-mode.el, verilog-mode has:
;; Tell which-func-modes that imenu knows about verilog
(when (boundp 'which-func-modes)
(add-to-list 'which-func-modes 'verilog-mode))
When which-func-modes is t, this stops which-function-mode from working
with other modes.
Can these lines be removed please ?
AndyM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Minor bug in verilog-mode.el
2012-04-21 16:32 Minor bug in verilog-mode.el Andy Moreton
@ 2012-04-21 17:12 ` Juanma Barranquero
2012-04-21 17:33 ` Andy Moreton
0 siblings, 1 reply; 6+ messages in thread
From: Juanma Barranquero @ 2012-04-21 17:12 UTC (permalink / raw)
To: Andy Moreton; +Cc: emacs-devel
> When which-func-modes is t, this stops which-function-mode from working
> with other modes.
Fixed, thanks.
Juanma
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Minor bug in verilog-mode.el
2012-04-21 17:12 ` Juanma Barranquero
@ 2012-04-21 17:33 ` Andy Moreton
2012-04-21 17:39 ` Juanma Barranquero
2012-04-21 18:28 ` Andreas Schwab
0 siblings, 2 replies; 6+ messages in thread
From: Andy Moreton @ 2012-04-21 17:33 UTC (permalink / raw)
To: emacs-devel
On Sat 21 Apr 2012, Juanma Barranquero wrote:
>> When which-func-modes is t, this stops which-function-mode from working
>> with other modes.
>
> Fixed, thanks.
While diagnosing this issue, I found another. which-func-current is used
to print the function name in the mode line. This fails when using
which-function-mode on a perl script, as % chars in symbol names are not
escaped for printing in the mode line.
My local fix involved replacing "%" => "\%\%" in the string used in the
mode line format, but perhaps there needs to be a way to allow literal
strings in that context.
AndyM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Minor bug in verilog-mode.el
2012-04-21 17:33 ` Andy Moreton
@ 2012-04-21 17:39 ` Juanma Barranquero
2012-04-21 17:53 ` Andy Moreton
2012-04-21 18:28 ` Andreas Schwab
1 sibling, 1 reply; 6+ messages in thread
From: Juanma Barranquero @ 2012-04-21 17:39 UTC (permalink / raw)
To: Andy Moreton; +Cc: emacs-devel
On Sat, Apr 21, 2012 at 19:33, Andy Moreton <andrewjmoreton@gmail.com> wrote:
> While diagnosing this issue, I found another. which-func-current is used
> to print the function name in the mode line. This fails when using
> which-function-mode on a perl script, as % chars in symbol names are not
> escaped for printing in the mode line.
Could you show an example? % is not a common character in Perl function names.
Juanma
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Minor bug in verilog-mode.el
2012-04-21 17:39 ` Juanma Barranquero
@ 2012-04-21 17:53 ` Andy Moreton
0 siblings, 0 replies; 6+ messages in thread
From: Andy Moreton @ 2012-04-21 17:53 UTC (permalink / raw)
To: emacs-devel
On Sat 21 Apr 2012, Juanma Barranquero wrote:
> On Sat, Apr 21, 2012 at 19:33, Andy Moreton <andrewjmoreton@gmail.com> wrote:
>
>> While diagnosing this issue, I found another. which-func-current is used
>> to print the function name in the mode line. This fails when using
>> which-function-mode on a perl script, as % chars in symbol names are not
>> escaped for printing in the mode line.
>
> Could you show an example? % is not a common character in Perl function names.
I can't seem to reproduce this any more. From memory I think it was from
a script where which-func did not show the package name, and tried to
use the name of a hash from the package instead.
AndyM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Minor bug in verilog-mode.el
2012-04-21 17:33 ` Andy Moreton
2012-04-21 17:39 ` Juanma Barranquero
@ 2012-04-21 18:28 ` Andreas Schwab
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2012-04-21 18:28 UTC (permalink / raw)
To: Andy Moreton; +Cc: emacs-devel
Andy Moreton <andrewjmoreton@gmail.com> writes:
> While diagnosing this issue, I found another. which-func-current is used
> to print the function name in the mode line. This fails when using
> which-function-mode on a perl script, as % chars in symbol names are not
> escaped for printing in the mode line.
Fixed.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-21 18:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-21 16:32 Minor bug in verilog-mode.el Andy Moreton
2012-04-21 17:12 ` Juanma Barranquero
2012-04-21 17:33 ` Andy Moreton
2012-04-21 17:39 ` Juanma Barranquero
2012-04-21 17:53 ` Andy Moreton
2012-04-21 18:28 ` Andreas Schwab
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).