From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Replace XChar2b with unsigned in all font backends Date: Mon, 20 May 2019 13:05:17 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245727"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 20 14:06:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSh3Q-0011lK-Sf for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 14:06:09 +0200 Original-Received: from localhost ([127.0.0.1]:34536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSh3P-000311-TV for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 08:06:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSh2m-00030B-38 for emacs-devel@gnu.org; Mon, 20 May 2019 08:05:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSh2l-0006Bp-2k for emacs-devel@gnu.org; Mon, 20 May 2019 08:05:28 -0400 Original-Received: from [195.159.176.226] (port=34976 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSh2k-0006AO-SZ for emacs-devel@gnu.org; Mon, 20 May 2019 08:05:27 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hSh2j-0010id-1Y for emacs-devel@gnu.org; Mon, 20 May 2019 14:05:25 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:lQEjJSVYxlxvn480/14R4iB6t+Y= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236786 Archived-At: On Mon 20 May 2019, martin rudalics wrote: > After this commit, building master on Windows here produces > > CC w32term.o > ../../src/w32font.c: In function 'w32font_draw': > ../../src/w32font.c:708:25: warning: passing argument 6 of 'ExtTextOutW' from incompatible pointer type [-Wincompatible-pointer-types] > s->char2b + from + i, 1, NULL); > ~~~~~~~~~~~~~~~~~^~~ > In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/windows.h:71, > from ../../src/w32font.c:20: > C:/msys64/mingw64/x86_64-w64-mingw32/include/wingdi.h:3347:100: note: expected 'LPCWSTR' {aka 'const short unsigned int *'} but argument is of type 'unsigned int *' > WINGDIAPI WINBOOL WINAPI ExtTextOutW(HDC hdc,int x,int y,UINT options,CONST RECT *lprect,LPCWSTR lpString,UINT c,CONST INT *lpDx); > ~~~~~~~~^~~~~~~~ > ../../src/w32font.c:711:57: warning: passing argument 6 of 'ExtTextOutW' from incompatible pointer type [-Wincompatible-pointer-types] > ExtTextOutW (s->hdc, x, y, options, NULL, s->char2b + from, len, NULL); > ~~~~~~~~~~^~~~~~ > In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/windows.h:71, > from ../../src/w32font.c:20: > C:/msys64/mingw64/x86_64-w64-mingw32/include/wingdi.h:3347:100: note: expected 'LPCWSTR' {aka 'const short unsigned int *'} but argument is of type 'unsigned int *' > WINGDIAPI WINBOOL WINAPI ExtTextOutW(HDC hdc,int x,int y,UINT options,CONST RECT *lprect,LPCWSTR lpString,UINT c,CONST INT *lpDx); > ~~~~~~~~^~~~~~~~ > CC w32xfns.o > > and the resulting build is not usable. > > martin Confirmed. This patch replaces use of XChar2b (a 16bit type) with unsigned (usually 32bit) which seems wrong. AndyM