From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Failed to compile from last bzr repo Date: Wed, 06 Apr 2011 13:57:58 +0100 Message-ID: References: <87vcyugxgs.fsf@gnu.org> <87wrjab38x.fsf@gmail.com> <83d3l1x6i6.fsf@gnu.org> <87pqp07lmg.fsf@gmail.com> <83tyecvdwj.fsf@gnu.org> <83ipusulpf.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1302094703 17397 80.91.229.12 (6 Apr 2011 12:58:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 6 Apr 2011 12:58:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 06 14:58:19 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7SJP-0003EY-JZ for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2011 14:58:19 +0200 Original-Received: from localhost ([127.0.0.1]:51005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7SJP-0005DW-2s for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2011 08:58:19 -0400 Original-Received: from [140.186.70.92] (port=37908 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7SJL-0005DP-4C for emacs-devel@gnu.org; Wed, 06 Apr 2011 08:58:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7SJK-00054b-8g for emacs-devel@gnu.org; Wed, 06 Apr 2011 08:58:15 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:47353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7SJJ-00054G-Uz for emacs-devel@gnu.org; Wed, 06 Apr 2011 08:58:14 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q7SJG-000391-K8 for emacs-devel@gnu.org; Wed, 06 Apr 2011 14:58:10 +0200 Original-Received: from 193.34.186.16 ([193.34.186.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 06 Apr 2011 14:58:10 +0200 Original-Received: from andrewjmoreton by 193.34.186.16 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 06 Apr 2011 14:58:10 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 44 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 193.34.186.16 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (windows-nt) Cancel-Lock: sha1:CwtYotgU9jf617NM9RvpPKuxoGs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138231 Archived-At: On Wed 06 Apr 2011, Juanma Barranquero wrote: > On Wed, Apr 6, 2011 at 05:01, Eli Zaretskii wrote: > >> I think the above is much easier than any of the alternatives. > > Sure, and I agree with adding that change. > > But this method does not work if the user wants to --cflag > -DSITELOAD_PURESIZE_EXTRA=100000 > >> In >> particular, setting an environment variable sounds both ugly and >> dangerous to me (the risk of leaving it set is high). > > I don't like it either, but it's easier than trying to workaround the > =-is-a-separator issue. > >     Juanma Due to some changes made in the last day or so, the Win32 build no longer bootstraps. There are two issues that need fixing up: a) ATTRIBUTE_FORMAT() and ATTRIBUTE_FORMAT_PRINTF() are undefined. b) careadlinkatcwd() and careadlinkat are undefined in src/sysdep.c The missing macros in (a) can be worked around by adding a force-include header file: cmd.exe /C "configure.bat ${args} --with-gcc --no-cygwin \ --cflags -I$(cygpath -wm ${srcdir}/nt) \ --cflags -include --cflags user_defines.h \ " This forces inclusion of "nt/user_defines.h" which can then contain any user defined macro definitions or workarounds. Incorporating something like this into configure.bat would allow user defined macros while avoiding the problems with quoting '='. For MSVC based builds, I expect "--cflags /FI --cflags user_defines.h" to work in a similar fashion. AndyM