* Calc and bignums
@ 2019-06-26 3:12 Stefan Monnier
2019-06-26 12:32 ` Andy Moreton
2019-06-26 13:50 ` Bruce Stephens
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Monnier @ 2019-06-26 3:12 UTC (permalink / raw)
To: emacs-devel
I just pushed a patch to Calc which removes its homegrown
bignums, making it use "native" bignums instead.
I never really use Calc, so the testing was rather limited.
Knowing myself, I probably messed up at a few places.
Buyer beware,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Calc and bignums
2019-06-26 3:12 Calc and bignums Stefan Monnier
@ 2019-06-26 12:32 ` Andy Moreton
2019-06-26 13:50 ` Bruce Stephens
1 sibling, 0 replies; 4+ messages in thread
From: Andy Moreton @ 2019-06-26 12:32 UTC (permalink / raw)
To: emacs-devel
On Tue 25 Jun 2019, Stefan Monnier wrote:
> I just pushed a patch to Calc which removes its homegrown
> bignums, making it use "native" bignums instead.
>
> I never really use Calc, so the testing was rather limited.
> Knowing myself, I probably messed up at a few places.
If you were not able to test it properly, why did you push this change ?
At the least you could have written some test cases to show that patch
does not introduce obvious regressions.
Why the rush ?
AndyM
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Calc and bignums
2019-06-26 3:12 Calc and bignums Stefan Monnier
2019-06-26 12:32 ` Andy Moreton
@ 2019-06-26 13:50 ` Bruce Stephens
2019-06-26 14:22 ` Stefan Monnier
1 sibling, 1 reply; 4+ messages in thread
From: Bruce Stephens @ 2019-06-26 13:50 UTC (permalink / raw)
To: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I just pushed a patch to Calc which removes its homegrown
> bignums, making it use "native" bignums instead.
>
> I never really use Calc, so the testing was rather limited.
> Knowing myself, I probably messed up at a few places.
There's one (trivial) bug:
--- a/lisp/calc/calc-ext.el
+++ b/lisp/calc/calc-ext.el
@@ -2138,7 +2138,7 @@ 'math-anglep
(defalias 'math-numberp #'Math-numberp)
;;; True if A is a complex number or angle. [P x] [Public]
-(defalias 'math-scalarp #'#'Math-scalarp)
+(defalias 'math-scalarp #'Math-scalarp)
;;; True if A is a vector. [P x] [Public]
(defalias 'math-vectorp #'Math-vectorp)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-26 14:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-26 3:12 Calc and bignums Stefan Monnier
2019-06-26 12:32 ` Andy Moreton
2019-06-26 13:50 ` Bruce Stephens
2019-06-26 14:22 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).