From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Improve Gravatar support Date: Mon, 22 Jul 2019 14:39:14 +0100 Message-ID: References: <87muh6w6c6.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27053"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 22 15:39:31 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpYXK-0006un-K2 for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 15:39:30 +0200 Original-Received: from localhost ([::1]:33688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYXJ-0004og-Eu for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 09:39:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54143) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYXH-0004oS-M3 for emacs-devel@gnu.org; Mon, 22 Jul 2019 09:39:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpYXG-00030q-5Q for emacs-devel@gnu.org; Mon, 22 Jul 2019 09:39:27 -0400 Original-Received: from 195-159-176-226.customer.powertech.no ([195.159.176.226]:57392 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpYXF-0002z7-UB for emacs-devel@gnu.org; Mon, 22 Jul 2019 09:39:26 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hpYXD-0006r2-A4 for emacs-devel@gnu.org; Mon, 22 Jul 2019 15:39:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:0b6FAp7rx08ell0f4EqCfyXnaeY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238786 Archived-At: On Mon 22 Jul 2019, Basil L. Contovounesios wrote: > The attached patch adds support for more Gravatar features, improves > existing docs, and reduces some code duplication. WDYT? This patch seems to mix three things: - conversion to lexical binding - minor bugfixes - new features It is better to put each in a separate patch, to ease later bisection if needed. AndyM