From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Tue, 07 Aug 2018 12:17:28 +0100 Message-ID: References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> <87ftzrknyg.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533640544 4596 195.159.176.226 (7 Aug 2018 11:15:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2018 11:15:44 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 07 13:15:40 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmzxk-000179-7r for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2018 13:15:40 +0200 Original-Received: from localhost ([::1]:38503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmzzq-0006TP-LD for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2018 07:17:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmzzj-0006T5-V2 for emacs-devel@gnu.org; Tue, 07 Aug 2018 07:17:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmzzf-0000M7-UV for emacs-devel@gnu.org; Tue, 07 Aug 2018 07:17:43 -0400 Original-Received: from [195.159.176.226] (port=48791 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmzzf-0000Kf-KX for emacs-devel@gnu.org; Tue, 07 Aug 2018 07:17:39 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fmzxU-0000pM-57 for emacs-devel@gnu.org; Tue, 07 Aug 2018 13:15:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 39 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:nRxgwY4rPhjZVDKXHqytfiajFm0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228265 Archived-At: On Mon 06 Aug 2018, Tom Tromey wrote: >>>>>> "Andy" == Andy Moreton writes: > > Andy> ok, then maybe XINTEGER would still be useful. > Andy> On the bignum branch that code would now be: > Andy> if (FIXNATP (foo)) > Andy> x = XFASTINT (foo); > Andy> Perhaps XFASTINT should be renamed XFIXNAT to be consistent. > > It's easy to do these kinds of renamings, since it's just a simple > "sed -i". > > So, if Eli or Paul can let me know what they want, I can do it. >From other comments in this thread, it seems there is agreement that ending up with consistent naming is desirable. > As far as I know the branch is ready. I have two uncommitted patches: > one for dumping (just sent) and one to use mpz_import (that I can't > test). The second one seems like a minor improvement and could probably > be dropped. The mpz_import patch [1] results in appears to cause a problem in the CCL tests. I'll report back when I have time to look into it further. I haven't yet tested the purecopy patch [2], as nothing needs it yet. The patch also uses the underlying representation rather than using the low level API, so I think the patch still needs some work. However it should not block merging to master. AndyM [1] mpz_import patch: http://lists.gnu.org/archive/html/emacs-devel/2018-08/msg00103.html [2] purecopy patch: http://lists.gnu.org/archive/html/emacs-devel/2018-08/msg00182.html