From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Regexp error scan (March 26) Date: Wed, 27 Mar 2019 13:55:09 +0000 Message-ID: References: <0E648A80-8673-44DB-B481-981474AC3D7C@acm.org> <77419a89-ce9f-919b-c221-c7a3b938587a@cs.ucla.edu> <87h8bpvv74.fsf@tcd.ie> <7E84CED0-9E85-45FB-8BBF-B87ED51F4818@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="264356"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 27 14:55:28 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h991b-0016Sn-KG for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 14:55:27 +0100 Original-Received: from localhost ([127.0.0.1]:48155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h991a-0007o4-Mf for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 09:55:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h991U-0007nx-6G for emacs-devel@gnu.org; Wed, 27 Mar 2019 09:55:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h991S-0000Qz-LO for emacs-devel@gnu.org; Wed, 27 Mar 2019 09:55:19 -0400 Original-Received: from [195.159.176.226] (port=48248 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h991S-0000Q5-2t for emacs-devel@gnu.org; Wed, 27 Mar 2019 09:55:18 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h991Q-0016Dk-0x for emacs-devel@gnu.org; Wed, 27 Mar 2019 14:55:16 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:2GAv+4twFR4jBK5a/2eXdSqaspE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234769 Archived-At: On Wed 27 Mar 2019, Mattias Engdegård wrote: > 27 mars 2019 kl. 04.43 skrev Basil L. Contovounesios : >> >> Paul Eggert writes: >> >>> (replace-regexp-in-string >>> - (format "[%s]" >>> - (mapconcat (lambda (char) >>> - (regexp-quote (char-to-string char))) >>> - erc-lurker-ignore-chars "")) >>> + (regexp-opt (cl-delete-duplicates >>> + (mapcar #'char-to-string erc-lurker-ignore-chars))) >>> "" nick) >>> nick)) >> >> regexp-opt already deletes duplicates, so you can just: >> >> (regexp-opt (mapcar #'char-to-string erc-lurker-ignore-chars)) >> >> Besides, cl-delete-duplicates defaults to eql for equality, so it's a >> no-op here anyway. > > Or perhaps: > > (regexp-opt-charset (append erc-lurker-ignore-chars nil)) This *-charset naming is helpful, as it reminds users of the expected argument type. Given the previously noted problems with incorrect arguments for `skip-chars-forward' and `skip-chars-backward', would it make sense to rename these functions to `forward-charset' and `backward-charset' ? AndyM