From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Mon, 06 Aug 2018 19:12:34 +0100 Message-ID: References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533579051 23916 195.159.176.226 (6 Aug 2018 18:10:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 6 Aug 2018 18:10:51 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 06 20:10:47 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmjxu-00066e-Ho for ged-emacs-devel@m.gmane.org; Mon, 06 Aug 2018 20:10:46 +0200 Original-Received: from localhost ([::1]:35580 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmk01-00073o-8H for ged-emacs-devel@m.gmane.org; Mon, 06 Aug 2018 14:12:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmjzq-000724-4B for emacs-devel@gnu.org; Mon, 06 Aug 2018 14:12:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmjzl-0000xY-QN for emacs-devel@gnu.org; Mon, 06 Aug 2018 14:12:46 -0400 Original-Received: from [195.159.176.226] (port=51014 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmjzl-0000wG-Hv for emacs-devel@gnu.org; Mon, 06 Aug 2018 14:12:41 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fmjxc-0005rC-OY for emacs-devel@gnu.org; Mon, 06 Aug 2018 20:10:28 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 40 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:NCyJoU6b5+IgTejcxyvwSrjEsqI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228236 Archived-At: On Sun 05 Aug 2018, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Sun, 05 Aug 2018 12:36:13 +0100 >> >> >> That allows "XBIGNUM(value)->value" to be replaced with "XBIGNUM(value)" >> >> in all callers. >> > >> > That would go against the convention with all the other Xfoo macros. >> >> True, the only thing with similar behaviour being xmint_pointer. While >> inconsistent with the other Xfoo macros, it does reduce visual clutter >> in the callers. > > Yes, but then how do you access the C structure represented by a Lisp > bignum objects? The usual way is XBIGNUM(bignum), from which you can > access members other than 'value'. If XBIGNUM expands into the value, > we will need something else to do what XBIGNUM does now. > >> > However, I see your point, and so perhaps an additional macro, >> > XINTEGER, could call either XINT or XBIGNUM()->value, depending on the >> > argument type? >> >> I'm not sure that would help, as callers still need to know if the >> result is a bignum or fixnum to handle it correctly. > > That's fine, we have a lot of code like > > if (NATNUMP (foo)) > x = XFASTINT (foo); ok, then maybe XINTEGER would still be useful. On the bignum branch that code would now be: if (FIXNATP (foo)) x = XFASTINT (foo); Perhaps XFASTINT should be renamed XFIXNAT to be consistent. AndyM