unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: master c3e8381: * lisp/gnus/gnus-sum.el: Use lexical-binding
Date: Fri, 17 May 2019 17:06:59 +0100	[thread overview]
Message-ID: <vz11s0xvzdo.fsf@gmail.com> (raw)
In-Reply-To: 20190515175319.ACE4B20537@vcs0.savannah.gnu.org

On Wed 15 May 2019, Stefan Monnier wrote:

> branch: master
> commit c3e838166800d5af4be66e80c2be276905a73486
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * lisp/gnus/gnus-sum.el: Use lexical-binding

This commit causes problems with the display of thread related fields in
summary lines in the summary buffer.

`gnus-summary-line-format-alist' is used to expand the summary line
format string. The ?V, ?t and ?e formats expect `thread' to be bound
dynamically. Now that this file uses lexical binding that no longer
works.

Several entries in the alist also use "(macroexpand (mail-header-..."
which appears to no longer be needed, as the mail header accessors are
now functions not macros.

    AndyM




       reply	other threads:[~2019-05-17 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190515175318.10237.53148@vcs0.savannah.gnu.org>
     [not found] ` <20190515175319.ACE4B20537@vcs0.savannah.gnu.org>
2019-05-17 16:06   ` Andy Moreton [this message]
2019-05-17 16:45     ` master c3e8381: * lisp/gnus/gnus-sum.el: Use lexical-binding Stefan Monnier
2019-05-17 16:48       ` Stefan Monnier
2019-05-17 18:15         ` Andy Moreton
2019-05-17 18:43           ` Stefan Monnier
2019-05-18  8:10           ` Bastien
2019-05-18 13:00             ` Stefan Monnier
2019-05-18 14:45               ` Bastien
2019-05-18 13:13             ` Andy Moreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vz11s0xvzdo.fsf@gmail.com \
    --to=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).