Re: Changes to emacs/lisp/ChangeLog,v

Re: Changes to emacs/lisp/ChangeLog,v

[Glenn Morris]

Alan Mackenzie wrote:

> +2007-04-07  Alan Mackenzie  <acm@muc.de>
> +
> +	* progmodes/cc-cmds.el (c-electric-paren): clean-up
> +	space-before-funcall: only insert space when on identifier, etc.
> +	Patch by David Hansen.
> +

Please don't make ChangeLog entries like this. If this patch was
written by David Hansen, his name should appear at the top of the
entry, not yours.

Re: Changes to emacs/lisp/ChangeLog,v

[Glenn Morris]

Juanma Barranquero wrote:

>  2007-09-24  Adam Hupp  <adam@hupp.org>
>  
> -	* progmodes/python.el (run-python): Import emacs module without
> +	* progmodes/python.el (run-python): Import Emacs module without
>  	waiting; prevents lockup on error.

To continue my morning's nit-picking, I don't think this change is
correct. The entry refers to the Python module called "emacs", not the
"Emacs" program.

> -	* term/sun.el (scroll-down-in-place, scroll-up-in-place): Use
> -	forward-line instead of previous-line and next-line.
> +	* term/sun.el (scroll-down-in-place, scroll-up-in-place):
> +	Use forward-line instead of previous-line and next-line.

Also, could you and the others who seem to have their own rules about
ChangeLog formats please share them? Or modify the Emacs filling code
so it does the right thing.

Re: Changes to emacs/lisp/ChangeLog,v

[Juanma Barranquero]

On 9/25/07, Glenn Morris <rgm+gmane@gnu.org> wrote:

> To continue my morning's nit-picking, I don't think this change is
> correct. The entry refers to the Python module called "emacs", not the
> "Emacs" program.

Sorry. My mistake.

> Also, could you and the others who seem to have their own rules about
> ChangeLog formats please share them?

99% of the changes I do in Changelogs are obvious errors: misspellings
and typos and the like. Every now and then (but not often now) I move
a word up or down so it's not alone on a line, or just after the
colon.

> Or modify the Emacs filling code
> so it does the right thing.

I think that would be a good idea.

             Juanma

Re: Changes to emacs/lisp/ChangeLog,v

[Stefan Monnier]

>> -	* term/sun.el (scroll-down-in-place, scroll-up-in-place): Use
>> -	forward-line instead of previous-line and next-line.
>> +	* term/sun.el (scroll-down-in-place, scroll-up-in-place):
>> +	Use forward-line instead of previous-line and next-line.

> Also, could you and the others who seem to have their own rules about
> ChangeLog formats please share them? Or modify the Emacs filling code
> so it does the right thing.

I think the above change corresponds to the rule that says that it's
generally preferred for sentences to be on their own lines rather than
spread over 2 lines.
It's an approximate rule, linked to aesthetics, so it's difficult to write
a filling rule that understands it.


        Stefan

Re: Changes to emacs/lisp/ChangeLog,v

[Glenn Morris]

I think you deleted the wrong duplicate entries here - it should have
been the 2008-02-02 ones that went. I think Vinicius was one of the
few people making changes on both trunk and unicode-2 by hand. (Just
to make it more fun, I don't know if some changes were only made on
unicode).

Also, aren't your log entries off by a day? It was 2008-02-01 UTC when
you made the merge.

Another oddity: vc-bzr.el certainly wasn't newly installed today, but
the original changelog entry seems to be missing. Probably a pre-merge
problem.


> --- lisp/ChangeLog	1 Feb 2008 14:44:44 -0000	1.12701
> +++ lisp/ChangeLog	1 Feb 2008 16:01:11 -0000	1.12702
> @@ -6952,16 +6952,6 @@
>  
>  	* international/characters.el: Undo unwanted and unexplained change.
>  
> -2007-10-10  Vinicius Jose Latorre  <viniciusjl@ig.com.br>
> -
> -	* ps-print.el: Fix the usage of :foreground and :background face
> -	attributes.  Reported by Nikolaj Schumacher <n_schumacher@web.de>.
> -	(ps-print-version): New version 6.7.6.
> -	(ps-face-attributes, ps-face-attribute-list, ps-face-background):
> -	Fix code.
> -	(ps-face-foreground-color-p, ps-face-background-color-p)
> -	(ps-face-color-p): New inline funs.
> -
>  2007-10-10  Carsten Dominik  <dominik@science.uva.nl>
>  
>  	* textmodes/org.el (org-additional-option-like-keywords): New constant.
> @@ -10016,16 +10006,6 @@
>  
>  	* calc/calc.el (calc-language-alist): Add texinfo-mode.
>  
> -2007-08-16  Vinicius Jose Latorre  <viniciusjl@ig.com.br>
> -
> -	* ps-print.el (ps-header-font-size, ps-header-title-font-size)
> -	(ps-footer-font-size, ps-line-number-font-size, ps-line-spacing)
> -	(ps-paragraph-spacing): Docstring fix.
> -
> -2007-08-16  Glenn Morris  <rgm@gnu.org>
> -
> -	* ps-print.el (ps-font-size): Doc fix.
> -
>  2007-08-16  Richard Stallman  <rms@gnu.org>
>  
>  	* emacs-lisp/copyright.el (copyright-names-regexp): Add custom group.
> @@ -10336,13 +10316,6 @@
>  	(tex-font-script-display, tex-font-lock-suscript): Change from a cons
>  	cell to a list of 2 elements to simplify the unfontify code.
>  
> -2007-08-08  Vinicius Jose Latorre  <viniciusjl@ig.com.br>
> -
> -	* ps-print.el (ps-default-fg, ps-default-bg): Docstring fix.
> -	(ps-begin-job): Use ps-default-fg and ps-default-bg only when
> -	ps-print-color-p is neither nil nor black-white.  Reported by Christian
> -	Schlauer <cs-muelleimer-rubbish.bin@arcor.de>.
> -
>  2007-08-08  Andreas Schwab  <schwab@suse.de>
>  
>  	* mail/mailabbrev.el (sendmail-pre-abbrev-expand-hook): Check for
> @@ -10424,10 +10397,6 @@
>  	format-mode-line because it may be a list,
>  	e.g., (sgml-xml-mode "XML" "SGML"), and not a string.
>  
> -2007-08-06  Vinicius Jose Latorre  <viniciusig@ig.com.br>
> -
> -	* printing.el (pr-update-menus): Docstring fix.
> -
>  2007-08-06  Jason Rumney  <jasonr@gnu.org>
>  
>  	* menu-bar.el (menu-bar-vc-filter): Use vc-call-backend.
> @@ -10471,11 +10440,6 @@
>  	* calc/calc-nlfit.el (math-nlfit-curve): Remove unnecessary variables.
>  	(math-nlfit-givens): Let bind free variables.
>  
> -2007-08-05  Vinicius Jose Latorre  <viniciusig@ig.com.br>
> -
> -	* printing.el: Require lpr and ps-print when loading printing package.
> -	Reported by Glenn Morris <rgm@gnu.org>.
> -
>  2007-08-05  Michael Albinus  <michael.albinus@gmx.de>
>  
>  	* files.el (set-auto-mode): Handle also remote files wrt
> @@ -10505,13 +10469,6 @@
>  	may match up to 4 lines.
>  	(diff-beginning-of-file-and-junk): Rewrite.
>  
> -2007-08-03  Vinicius Jose Latorre  <viniciusjl@ig.com.br>
> -
> -	* printing.el: Evaluate require only during compilation.
> -	(pr-version): New version 6.9.1.
> -	(deactivate-mark): Replace (defvar VAR nil) by (defvar VAR).
> -	(pr-global-menubar): Fix code.
> -
>  2007-08-03  Dan Nicolaescu  <dann@ics.uci.edu>
>  
>  	* term.el (term-erase-in-display): Fix case when point is not at
> @@ -10802,59 +10759,6 @@
>  	* vc-git.el (vc-git-revision-table)
>  	(vc-git-revision-completion-table): New functions.
>  
> -2007-07-26  Vinicius Jose Latorre  <viniciusjl@ig.com.br>
> -
> -	* progmodes/ebnf-abn.el (ebnf-abn-skip-comment):
> -	* progmodes/ebnf-bnf.el (ebnf-bnf-skip-comment):
> -	* progmodes/ebnf-dtd.el (ebnf-dtd-skip-comment):
> -	* progmodes/ebnf-ebx.el (ebnf-ebx-skip-comment):
> -	* progmodes/ebnf-iso.el (ebnf-iso-skip-comment):
> -	* progmodes/ebnf-yac.el (ebnf-yac-skip-comment): New version.
> -	New command actions for EPS header and EPS footer.
> -
> -	* progmodes/ebnf2ps.el: New command actions for EPS header and EPS
> -	footer.  Fix some problems with one-or-more, zero-or-more and
> -	alternative constructions generation.  Some log messages
> -	implementation.  Doc fix.
> -	(ebnf-version): New version 4.4.
> -	(ebnf-eps-header-font, ebnf-eps-header, ebnf-eps-footer-font)
> -	(ebnf-eps-footer, ebnf-log): New options.
> -	(ebnf-find-style, ebnf-eps-header-footer, ebnf-eps-header)
> -	(ebnf-eps-footer, ebnf-eps-string, ebnf-eps-header-footer-comment)
> -	(ebnf-eps-header-footer-p, ebnf-eps-header-comment)
> -	(ebnf-eps-footer-comment, ebnf-eps-header-footer-file)
> -	(ebnf-eps-header-footer-set, ebnf-log-header, ebnf-log): New funs.
> -	(ebnf-style-custom-list, ebnf-style-database): Put new values.
> -	(ebnf-print-directory, ebnf-print-file, ebnf-print-buffer)
> -	(ebnf-print-region, ebnf-spool-directory, ebnf-spool-file)
> -	(ebnf-spool-buffer, ebnf-spool-region, ebnf-eps-directory)
> -	(ebnf-eps-file, ebnf-eps-buffer, ebnf-eps-region)
> -	(ebnf-syntax-directory, ebnf-syntax-file, ebnf-syntax-buffer)
> -	(ebnf-syntax-region, ebnf-parse-and-sort, ebnf-begin-job)
> -	(ebnf-dimensions, ebnf-production-dimension, ebnf-terminal-dimension)
> -	(ebnf-non-terminal-dimension, ebnf-special-dimension)
> -	(ebnf-terminal-dimension1, ebnf-repeat-dimension)
> -	(ebnf-except-dimension, ebnf-alternative-dimension)
> -	(ebnf-optional-dimension, ebnf-one-or-more-dimension)
> -	(ebnf-zero-or-more-dimension, ebnf-sequence-dimension): Insert log
> -	message fun.
> -	(ebnf-setup, ebnf-generate-one-or-more, ebnf-generate-zero-or-more)
> -	(ebnf-begin-job, ebnf-begin-file, ebnf-eps-finish-and-write)
> -	(ebnf-insert-ebnf-prologue, ebnf-production-dimension)
> -	(ebnf-terminal-dimension1, ebnf-alternative-dimension)
> -	(ebnf-one-or-more-dimension, ebnf-zero-or-more-dimension)
> -	(ebnf-eps-add-context, ebnf-eps-add-production): Fix code.
> -	(ebnf-eps-filename, ebnf-trim-right): Replace `?\s' by `?\ ' to keep
> -	compatibility with Emacs 20 & 21.
> -	(ebnf-eps-header-comment, ebnf-eps-footer-comment)
> -	(ebnf-eps-file-alist, ebnf-basic-width-extra)
> -	(ebnf-basic-empty-height): New vars.
> -	(ebnf-prologue): Fix PostScript code.
> -	(ebnf-make-empty, ebnf-make-terminal1, ebnf-make-or-more1)
> -	(ebnf-make-production, ebnf-make-alternative, ebnf-make-optional)
> -	(ebnf-make-except, ebnf-make-repeat, ebnf-make-sequence)
> -	(ebnf-make-dup-sequence, ebnf-token-alternative): Add comments.
> -
>  2007-07-25  Glenn Morris  <rgm@gnu.org>
>  
>  	* Relicense all FSF files to GPLv3 or later.
> @@ -10921,14 +10825,6 @@
>  	* vc-git.el (vc-git-log-view-mode): Port to the multi-file vc interface.
>  	(vc-git-create-snapshot, vc-git-retrieve-snapshot): New functions.
>  
> -2007-07-25  Vinicius Jose Latorre  <viniciusjl@ig.com.br>
> -
> -	* ps-print.el (ps-multibyte-buffer): Docstring fix.
> -
> -	* ps-mule.el: Doc fix.
> -	(ps-multibyte-buffer, ps-mule-font-info-database-default)
> -	(ps-mule-external-libraries, ps-mule-begin-job): Docstring fix.
> -
>  2007-07-25  Glenn Morris  <rgm@gnu.org>
>  
>  	* calendar/cal-tex.el (cal-tex-which-days, cal-tex-holidays)
> @@ -11312,18 +11208,6 @@
>  
>  	* vc-hg.el (vc-hg-diff): Use vc-hg-command.
>  
> -2007-07-20  Vinicius Jose Latorre  <viniciusjl@ig.com.br>
> -
> -	* ps-print.el: Problem with foreground and background color when
> -	printing a buffer with and without faces.  Reported by Christian
> -	Schlauer <cs-muelleimer-rubbish.bin@arcor.de>.
> -	(ps-print-version): New version 6.7.5.
> -	(ps-default-fg): Change default value to nil, so black color is used
> -	when a face does not specify a foreground color.
> -	(ps-default-bg): Change default value to nil, so white color is used
> -	for background color.
> -	(ps-begin-job): Fix code.
> -
>  2007-07-20  Eli Zaretskii  <eliz@gnu.org>
>  
>  	* makefile.w32-in (install-lisp-SH): Don't create subdirectories
> @@ -13568,32 +13452,6 @@
>  	for start and end positions.
>  	(ispell-word): Assume END is a marker.
>  
> -2007-05-17  Vinicius Jose Latorre  <viniciusjl@ig.com.br>
> -
> -	* printing.el: Group together all XEmacs/Emacs definitions.
> -	(pr-version): New version 6.9.
> -	(pr-global-menubar, pr-menu-char-height, pr-menu-char-width): New funs.
> -	(pr-menu-char-height, pr-menu-char-width): Fix initialization code.
> -	(pr-menu-bind): Fix code.
> -	(pr-e-frame-char-height, pr-e-frame-char-width)
> -	(pr-e-mouse-pixel-position, pr-x-add-submenu, pr-x-event-function)
> -	(pr-x-event-object, pr-x-find-menu-item, pr-x-font-height)
> -	(pr-x-font-width, pr-x-get-popup-menu-response, pr-x-make-event)
> -	(pr-x-misc-user-event-p, pr-x-relabel-menu-item, pr-x-event-x-pixel)
> -	(pr-x-event-y-pixel): Aliases eliminated.
> -	(pr-xemacs-global-menubar): Macro moved.
> -	(current-menubar, current-mouse-event, zmacs-region-stays)
> -	(deactivate-mark, pr-menu-position, pr-menu-state, pr-ps-name-old)
> -	(pr-txt-name-old, pr-ps-utility-old, pr-even-or-odd-old, pr-temp-menu):
> -	Vars moved.
> -	(pr-region-active-p, pr-menu-position, pr-menu-lookup, pr-menu-lock)
> -	(pr-update-mode-line, pr-do-update-menus, pr-menu-alist)
> -	(pr-relabel-menu-item, pr-menu-set-ps-title, pr-menu-set-txt-title)
> -	(pr-menu-set-utility-title, pr-even-or-odd-pages)
> -	(pr-f-set-keymap-parents, pr-f-set-keymap-name, pr-f-read-string)
> -	(pr-keep-region-active, pr-menu-get-item, pr-menu-set-item-name): Funs
> -	moved.
> -
>  2007-05-17  Christian Plate  <cplate@web.de>  (tiny change)
>  
>  	* textmodes/sgml-mode.el (sgml-tag):
> @@ -13656,15 +13514,6 @@
>  	* files.el (mode-require-final-newline, require-final-newline)
>  	(enable-local-variables, enable-local-eval): Doc fixes.
>  
> -2007-05-13  Vinicius Jose Latorre  <viniciusjl@ig.com.br>
> -
> -	* ps-print.el: Use default color when foreground or background color
> -	are unspecified.  Reported by Leo <sdl.web@gmail.com>.
> -	(ps-print-version): New version 6.7.4.
> -	(ps-rgb-color): New argument.  Use default color when color is
> -	unspecified.
> -	(ps-begin-job): Fix code.
> -
>  2007-05-12  Chong Yidong  <cyd@stupidchicken.com>
>  
>  	* longlines.el (longlines-mode): Make longlines-auto-wrap

Re: Changes to emacs/lisp/ChangeLog,v

[Miles Bader]

Glenn Morris <rgm+gmane@gnu.org> writes:
> I think you deleted the wrong duplicate entries here - it should have
> been the 2008-02-02 ones that went. I think Vinicius was one of the
> few people making changes on both trunk and unicode-2 by hand. (Just
> to make it more fun, I don't know if some changes were only made on
> unicode).

I didn't delete those by hand, the "2008-02-02 entries" came from the
unicode branch (where they originally had a date roughly similar to the
trunk entries), and I had removed the redundant trunk entries when
previously merging the trunk into the unicode branch.

You're right that arguably the trunk entries should win in such a case,
but I doubt it really matters all that much.  If somebody wants to clean
such things up, go ahead, I guess...

> Also, aren't your log entries off by a day? It was 2008-02-01 UTC when
> you made the merge.

Whoops, I didn't realize the Emacs ChangeLogs were set up to use UTC.

> Another oddity: vc-bzr.el certainly wasn't newly installed today, but
> the original changelog entry seems to be missing. Probably a pre-merge
> problem.

Dunno.

-Miles

-- 
Bacchus, n. A convenient deity invented by the ancients as an excuse for
getting drunk.

Re: Changes to emacs/lisp/ChangeLog,v

[Glenn Morris]

Miles Bader wrote:

> You're right that arguably the trunk entries should win in such a case,
> but I doubt it really matters all that much.  If somebody wants to clean
> such things up, go ahead, I guess...

Done.

> Whoops, I didn't realize the Emacs ChangeLogs were set up to use UTC.

I set the merge dates to 2008-02-01.

>> Another oddity: vc-bzr.el certainly wasn't newly installed today, but
>> the original changelog entry seems to be missing. Probably a pre-merge
>> problem.
>
> Dunno.

I found the original entry (perhaps I was just missing it) and deleted
the merge entry.