From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mitchel Humpherys Newsgroups: gmane.emacs.devel Subject: Overlay modification-hooks no longer running after 564d811725 (under certain configurations) Date: Thu, 10 Dec 2015 15:52:34 -0800 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1449791589 6255 80.91.229.3 (10 Dec 2015 23:53:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Dec 2015 23:53:09 +0000 (UTC) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 11 00:53:02 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7B1B-0003t2-7w for ged-emacs-devel@m.gmane.org; Fri, 11 Dec 2015 00:53:01 +0100 Original-Received: from localhost ([::1]:44941 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7B1A-0004ty-N9 for ged-emacs-devel@m.gmane.org; Thu, 10 Dec 2015 18:53:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7B0s-0004pC-8N for emacs-devel@gnu.org; Thu, 10 Dec 2015 18:52:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7B0r-0001bt-Cm for emacs-devel@gnu.org; Thu, 10 Dec 2015 18:52:42 -0500 Original-Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]:34444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7B0n-0001b9-Jm; Thu, 10 Dec 2015 18:52:37 -0500 Original-Received: by pacwq6 with SMTP id wq6so55020982pac.1; Thu, 10 Dec 2015 15:52:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:mime-version :content-type; bh=gEI+1mvNwKl8l9jE86wXzBGsYwLc2F+AeObKk6MBvE0=; b=dAB1IVYsH4A4lTSzJ/l3alBE8AbbDlF67XACWJsSDhMFoB32gmo6w45enHMYG9G2t1 l95va/9NYZecVINBcod4xbD4LPeQ509wsOBN1U5qhQf3mumrLkXQfGc4TkF7PY4aRpW7 9HNJNmBYdb0+grSQo9L18Zq3831+1HaHwEQjjk/AVC5tJTgXspqR+zIA6jGZTirsoukl t0umwEpTaRhFhPI42nbcRah1TZDGFvcinqnfL6NmH01EbN1ndTvwaj+cY0UXqAcxtRbv /rqT71d37qjVojRW5xbDpla6kGWraMCS1TrwccOzvRmwBwXCrzTwxcQQ4fLMnd9fKcQE hwYg== X-Received: by 10.66.138.101 with SMTP id qp5mr20625959pab.113.1449791556703; Thu, 10 Dec 2015 15:52:36 -0800 (PST) Original-Received: from mitchelh-linux (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id c79sm20767018pfj.71.2015.12.10.15.52.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Dec 2015 15:52:35 -0800 (PST) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196082 Archived-At: Hello, I noticed recently that iedit [1] stopped working on the emacs-25 and master branches. I finally got around to git bisect'ing it today and found that the breaking commit is: commit 564d811725596f15ecf543777e11504b47d2af86 Author: Eli Zaretskii Date: Fri Nov 6 17:19:39 2015 +0200 Don't invoke overlay modification hooks in wrong buffer The relevant iedit code seems to be: (overlay-put occurrence 'insert-in-front-hooks '(iedit-occurrence-update-hook)) (overlay-put occurrence 'insert-behind-hooks '(iedit-occurrence-update-hook)) (overlay-put occurrence 'modification-hooks '(iedit-occurrence-update-hook)) (from [2]). If I revert the commit above on the emacs-25 tip (or checkout that commit's parent), the hook does run and iedit works as expected. I apologize for not filing a bug, but I don't have an `emacs -Q' recipe, so there must be some other interaction with my config going on, which I haven't tracked down... It's also possible that iedit is incorrectly relying on some broken behavior. I was hoping someone might have an idea of what's going on here. If not, I'll continue pursuing a smaller repro recipe. [1] https://github.com/victorhge/iedit [2] https://github.com/victorhge/iedit/blob/master/iedit-lib.el#L287 -- Mitch