From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [alinsoar@voila.fr: EVAL and mouse selection in *Completions*] Date: Mon, 05 Mar 2007 21:50:27 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1173149555 2136 80.91.229.12 (6 Mar 2007 02:52:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 6 Mar 2007 02:52:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 06 03:52:28 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HOPmt-0001mY-6v for ged-emacs-devel@m.gmane.org; Tue, 06 Mar 2007 03:52:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HOPmt-0000r3-2e for ged-emacs-devel@m.gmane.org; Mon, 05 Mar 2007 21:52:27 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HOPmi-0000qt-RE for emacs-devel@gnu.org; Mon, 05 Mar 2007 21:52:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HOPmh-0000qe-EE for emacs-devel@gnu.org; Mon, 05 Mar 2007 21:52:15 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HOPmh-0000qb-B8 for emacs-devel@gnu.org; Mon, 05 Mar 2007 21:52:15 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HOPmg-0001Yj-Lm for emacs-devel@gnu.org; Mon, 05 Mar 2007 21:52:14 -0500 Original-Received: from [127.0.0.1] (helo=localhost) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HOPkz-00053a-BN; Mon, 05 Mar 2007 21:50:29 -0500 X-Spook: [Hello to all my friends and fans in domestic X-Ran: tn/6p__~ik%3"}*LG.)=n)8Z:9o*9k6BT3sVK4ge5@KvQ'{Dy.'RC7T-{ov+K1[x-Dje\: X-Hue: red X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67394 Archived-At: Richard Stallman wrote: > Would someone please fix this, then ack? > > From: A Soare > Subject: EVAL and mouse selection in *Completions* This bug was already mentioned by Martin Rudalics in reply to your mail "[bojohan+mail@bogus.example.com: Partial completion]" of Feb 24th. I suggest the following fix, but it seems both this bug and the other one need input from the OPs (or those who use partial completion), to test that the suggested fixes do not break anything else. *************** *** 710,722 **** (and completion-auto-help (eq last-command this-command)) (eq mode 'help)) (with-output-to-temp-buffer "*Completions*" (display-completion-list (sort helpposs 'string-lessp)) (with-current-buffer standard-output ;; Record which part of the buffer we are completing ;; so that choosing a completion from the list ;; knows how much old text to replace. ! (setq completion-base-size dirlength))) (PC-temp-minibuffer-message " [Next char not unique]")) nil))))) --- 718,734 ---- (and completion-auto-help (eq last-command this-command)) (eq mode 'help)) + (let ((width (minibuffer-prompt-width))) (with-output-to-temp-buffer "*Completions*" (display-completion-list (sort helpposs 'string-lessp)) (with-current-buffer standard-output ;; Record which part of the buffer we are completing ;; so that choosing a completion from the list ;; knows how much old text to replace. ! (setq completion-base-size ! (if dirname ! dirlength ! (- beg 1 width)))))) (PC-temp-minibuffer-message " [Next char not unique]")) nil)))))