unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann)
Cc: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>,
	emacs-devel@gnu.org
Subject: Re: occur-mode-hook run too early to be useful
Date: Wed, 28 Aug 2002 17:29:24 +0200	[thread overview]
Message-ID: <vafy9arq9wr.fsf@INBOX.auto.emacs.devel.tok.lucy.cs.uni-dortmund.de> (raw)
In-Reply-To: <20020828164804.A71C.LEKTU@terra.es> (Juanma Barranquero's message of "Wed, 28 Aug 2002 17:06:20 +0200")

Juanma Barranquero <lektu@terra.es> writes:

> But in this case things aren't that clear, as the distinction between
> code in occur-mode and code in occur-1 seems rather arbitrary:
>
>  1. occur-mode is only called from occur-1
>  2. occur-mode is called unconditionally
>  3. occur-1 is the engine to all the interactive occur functions
>  4. M-x occur-mode in a non-occur buffer is meaningless
>  5. occur-mode-hook now serves almost no practical purpose

How about making the distinction less arbitrary?

How about this:  Rename occur-mode to occur-setup or occur-initialize
or occur-frobnicate, make a new function occur-mode which just sets up
keymaps and such stuff, call that function at the end of occur-1 and
run the hook from there.  WDYT?

Caveat: I haven't even looked at the code!

kai
-- 
A large number of young women don't trust men with beards.  (BFBS Radio)

  parent reply	other threads:[~2002-08-28 15:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-28  9:16 occur-mode-hook run too early to be useful Juanma Barranquero
2002-08-28 14:30 ` Stefan Monnier
2002-08-28 15:06   ` Juanma Barranquero
2002-08-28 15:11     ` Stefan Monnier
2002-08-28 15:25       ` Juanma Barranquero
2002-08-28 15:30         ` Juanma Barranquero
2002-08-29 17:50       ` Richard Stallman
2002-08-30  2:14         ` Juanma Barranquero
2002-08-28 15:29     ` Kai Großjohann [this message]
2002-08-28 15:32       ` Stefan Monnier
2002-08-28 15:39         ` Kai Großjohann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vafy9arq9wr.fsf@INBOX.auto.emacs.devel.tok.lucy.cs.uni-dortmund.de \
    --to=kai.grossjohann@cs.uni-dortmund.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier+gnu/emacs@rum.cs.yale.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).