tool bar icons not updated according to :active condition

tool bar icons not updated according to :active condition

[Reiner Steib]

Hi,

`gnus-group-mode-map' contains the following menu entry (see
`gnus-group-make-menu-bar'):

  (easy-menu-define gnus-group-reading-menu gnus-group-mode-map ""
    `("Group"
      [...]
      ["Describe" gnus-group-describe-group
        :active (gnus-group-group-name) ...]

I.e. this menu item should be inactive[1] if the point isn't on a
group line (e.g. on non-group lines when using topics mode [2]).  In
the menu, this works correctly, i.e. the menu item is disabled
(probably because the menu is updated when clicking on "Group").

In `gnus-group-make-tool-bar' the describe-group entry is also added
to the tool bar (icon: etc/images/gnus/describe-group.xpm):

  (tool-bar-add-item-from-menu
    'gnus-group-describe-group "describe-group" gnus-group-mode-map)

But after moving up/down in the group buffer (C-p/C-n), the icon is
not updated (enabled/disabled) when changing from a group to a topic
line and vice versa.

After `C-l' (or after `redraw-frame' [3]), the correct icon is
displayed.  A workaround could be to redraw the frame after every
point-motion (is there a after-point-motion-hook?).

Bye, Reiner.

[1]
,----[ <f1> f gnus-group-group-name RET ]
| gnus-group-group-name is a compiled Lisp function in `gnus-group.el'.
| (gnus-group-group-name)
| 
| Get the name of the newsgroup on the current line.
`----

[2]
,----
| [ Gnus -- 6456 ]
|   [ misc -- 11 ]
|          1: nnml:test 
|         10: nndraft:drafts 
| [...]
`----

[3] Tested with...

(global-set-key (kbd "<down>")
		(lambda (&optional arg)
		  (interactive)
		  (or arg (setq arg 1))
		  (next-line arg)
		  (redraw-frame (selected-frame))))
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: tool bar icons not updated according to :active condition

[Chong Yidong]

> In `gnus-group-make-tool-bar' the describe-group entry is also added
> to the tool bar (icon: etc/images/gnus/describe-group.xpm):
>
>   (tool-bar-add-item-from-menu
>     'gnus-group-describe-group "describe-group" gnus-group-mode-map)
>
> But after moving up/down in the group buffer (C-p/C-n), the icon is
> not updated (enabled/disabled) when changing from a group to a topic
> line and vice versa.
>
> After `C-l' (or after `redraw-frame' [3]), the correct icon is
> displayed.  A workaround could be to redraw the frame after every
> point-motion (is there a after-point-motion-hook?).

You could use post-command-hook.

Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Fri, Feb 24 2006, Chong Yidong wrote:

>> In `gnus-group-make-tool-bar' the describe-group entry is also added
>> to the tool bar (icon: etc/images/gnus/describe-group.xpm):
>>
>>   (tool-bar-add-item-from-menu
>>     'gnus-group-describe-group "describe-group" gnus-group-mode-map)
>>
>> But after moving up/down in the group buffer (C-p/C-n), the icon is
>> not updated (enabled/disabled) when changing from a group to a topic
>> line and vice versa.
>>
>> After `C-l' (or after `redraw-frame' [3]), the correct icon is
>> displayed.  A workaround could be to redraw the frame after every
>> point-motion (is there a after-point-motion-hook?).
>
> You could use post-command-hook.

The following code updates the frame and the tool bar, but I think it
is too expensive (and maybe irritating for the user) because it
affects the whole frame, not only the tool bar.  Is it possible to
limit redrawing to the tool bar?

(defun rs-redraw ()
  (redraw-frame (selected-frame)))

(with-current-buffer gnus-group-buffer
  (add-to-list
   (make-local-variable 'post-command-hook)
   'rs-redraw))

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: tool bar icons not updated according to :active condition

[Kim F. Storm]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> The following code updates the frame and the tool bar, but I think it
> is too expensive (and maybe irritating for the user) because it
> affects the whole frame, not only the tool bar.  Is it possible to
> limit redrawing to the tool bar?

No, but I think force-window-update is cheaper than redraw-frame.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Sun, Feb 26 2006, Kim F. Storm wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> The following code updates the frame and the tool bar, but I think it
>> is too expensive (and maybe irritating for the user) because it
>> affects the whole frame, not only the tool bar.  Is it possible to
>> limit redrawing to the tool bar?
>
> No, but I think force-window-update is cheaper than redraw-frame.

But `force-window-update' doesn't update correctly (with GTK).

On Sun, Feb 26 2006, Chong Yidong wrote:

> I dunno if we want to redisplay the tool bar every time point moves,
> in general.

No.  Even Gnus Group buffer I found it annoying (e.g. using <up> or
<down> repeatedly).  When restricted to line changes and evaluated
when idle is might be okay.

> Maybe using post-command-hook is a good solution for those modes
> that need it.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: tool bar icons not updated according to :active condition

[Kim F. Storm]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

>> No, but I think force-window-update is cheaper than redraw-frame.
>
> But `force-window-update' doesn't update correctly (with GTK).

Would you pls. file a bug report explaining what the problem is.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Mon, Feb 27 2006, Kim F. Storm wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>>> No, but I think force-window-update is cheaper than redraw-frame.
>>
>> But `force-window-update' doesn't update correctly (with GTK).
>
> Would you pls. file a bug report explaining what the problem is.

I can't reproduce this problem anymore.  IOW: Updating the tool bar
using `force-window-update' via `run-with-idle-timer' works correctly.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: tool bar icons not updated according to :active condition

[Richard Stallman]

    I can't reproduce this problem anymore.  IOW: Updating the tool bar
    using `force-window-update' via `run-with-idle-timer' works correctly.

In that case, could you please delete the item from FOR-RELEASE?

Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Sun, Mar 05 2006, Richard Stallman wrote:

>     I can't reproduce this problem anymore.  IOW: Updating the tool bar
>     using `force-window-update' via `run-with-idle-timer' works correctly.
>
> In that case, could you please delete the item from FOR-RELEASE?

I think there is a misunderstanding here: The initial problem (tool
bar icons not updated according to :active condition) still exists.

[ As already pointed out in a previous message, I agree with Chong
  Yidong that this problem should not block the release.  (This bug
  has already been there in Emacs 21.1 (and version 5.9 of Gnus
  bundled with it) and I don't recall any complaints about it.) ]

As a workaround for Emacs not updating the icon according to the :active
condition automatically, I added a `redraw-frame' call inside
`run-with-idle-timer'.  Kim suggested to use `force-window-update'
instead which didn't appear to work for me.  But `force-window-update'
does work as good as `redraw-frame' in the workaround.

What I have in the relevant mode (gnus-group-mode) now is:

      (add-to-list (make-local-variable 'post-command-hook)
		   'gnus-group-redraw-check)

(defvar gnus-group-redraw-when-idle 2
  "When non-nil, redraw the Group buffer frame when idle.
Internal variable.")

(defun gnus-group-redraw-check ()
  "Check if we need to redraw the frame."
  (when gnus-group-redraw-when-idle
    (run-with-idle-timer gnus-group-redraw-when-idle
			 nil 'force-window-update)))

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: tool bar icons not updated according to :active condition

[Stefan Monnier]

>       (add-to-list (make-local-variable 'post-command-hook)
> 		   'gnus-group-redraw-check)

This is wrong.  It should be using add-hook.


        Stefan

Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Sun, Mar 05 2006, Stefan Monnier wrote:

>>       (add-to-list (make-local-variable 'post-command-hook)
>> 		   'gnus-group-redraw-check)
>
> This is wrong.  It should be using add-hook.

Thanks.  I will change this.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Sat, Feb 25 2006, Reiner Steib wrote:

> On Fri, Feb 24 2006, Chong Yidong wrote:
[...]
>>> But after moving up/down in the group buffer (C-p/C-n), the icon is
>>> not updated (enabled/disabled) when changing from a group to a topic
>>> line and vice versa.
>>>
>>> After `C-l' (or after `redraw-frame' [3]), the correct icon is
>>> displayed.  A workaround could be to redraw the frame after every
>>> point-motion (is there a after-point-motion-hook?).
>>
>> You could use post-command-hook.
>
> The following code updates the frame and the tool bar, but I think it
> is too expensive (and maybe irritating for the user) because it
> affects the whole frame, not only the tool bar.  

The following gives better results (but of course it is still a
workaround, not a fix).

--8<---------------cut here---------------start------------->8---
(defvar gnus-group-redraw-line-number nil
  "Internal variable.")

(defun gnus-group-redraw-check ()
  "Check if we need to redraw the frame."
  ;; Work around for
  ;; http://www.google.com/groups?as_umsgid=v9u0an3hti.fsf@marauder.physik.uni-ulm.de
  (when (and (not (featurep 'xemacs))
	     (boundp 'tool-bar-mode)
	     tool-bar-mode)
    (let ((no (line-number-at-pos)))
      (unless (eq gnus-group-redraw-line-number no)
	(setq gnus-group-redraw-line-number no)
	;; (run-with-idle-timer 1 nil 'menu-bar-update-buffers t)
	(run-with-idle-timer 1 nil 'redraw-frame (selected-frame))))))

(with-current-buffer gnus-group-buffer
  (add-to-list (make-local-variable 'post-command-hook)
	       'gnus-group-redraw-check))
--8<---------------cut here---------------end--------------->8---

> Is it possible to limit redrawing to the tool bar?

Is there an analog of `menu-bar-update-buffers' or
`menu-bar-update-buffers-1' for the tool bar?  BTW, maybe these
functions should have a doc string.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: tool bar icons not updated according to :active condition

[Chong Yidong]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> The following gives better results (but of course it is still a
> workaround, not a fix).

I dunno if we want to redisplay the tool bar every time point moves,
in general.  Maybe using post-command-hook is a good solution for
those modes that need it.

It would be nice to have a function that only redraws the toolbar,
though.

Re: tool bar icons not updated according to :active condition

[Richard Stallman]

    The following gives better results (but of course it is still a
    workaround, not a fix).

What is the underlying bug, for which this is a workaround?

Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Mon, Feb 27 2006, Richard Stallman wrote:

>     The following gives better results (but of course it is still a
>     workaround, not a fix).
>
> What is the underlying bug, for which this is a workaround?

The tool bar icons are not updated according to the :active condition.
I'm including the original report below.

You did already sent two reminder to emacs-devel, and added it to
admin/FOR-RELEASE:

,----[ admin/FOR-RELEASE ]
| * BUGS
| 
| ** Reiner Steib's 23 Jan 2006 bug report that tool bar icons don't update.
| URL/MID: http://mid.gmane.org/v9acdmrcse.fsf@marauder.physik.uni-ulm.de
`----

(I have added the URL/MID there.)

Bye, Reiner

My original report was:

--8<---------------cut here---------------start------------->8---
From: Reiner Steib <reinersteib+gmane@imap.cc>
Subject: tool bar icons not updated according to :active condition
Date: Mon, 23 Jan 2006 19:59:13 +0100
Message-ID: <v9acdmrcse.fsf@marauder.physik.uni-ulm.de>
Reply-To: Reiner Steib <Reiner.Steib@gmx.de>
To: emacs-devel@gnu.org

  (easy-menu-define gnus-group-reading-menu gnus-group-mode-map ""
    `("Group"
      [...]
      ["Describe" gnus-group-describe-group
        :active (gnus-group-group-name) ...]

I.e. this menu item should be inactive[1] if the point isn't on a
group line (e.g. on non-group lines when using topics mode [2]).  In
the menu, this works correctly, i.e. the menu item is disabled
(probably because the menu is updated when clicking on "Group").

In `gnus-group-make-tool-bar' the describe-group entry is also added
to the tool bar (icon: etc/images/gnus/describe-group.xpm):

  (tool-bar-add-item-from-menu
    'gnus-group-describe-group "describe-group" gnus-group-mode-map)

But after moving up/down in the group buffer (C-p/C-n), the icon is
not updated (enabled/disabled) when changing from a group to a topic
line and vice versa.

After `C-l' (or after `redraw-frame' [3]), the correct icon is
displayed.  A workaround could be to redraw the frame after every
point-motion (is there a after-point-motion-hook?).

Bye, Reiner.

[1]
,----[ <f1> f gnus-group-group-name RET ]
| gnus-group-group-name is a compiled Lisp function in `gnus-group.el'.
| (gnus-group-group-name)
| 
| Get the name of the newsgroup on the current line.
`----

[2]
,----
| [ Gnus -- 6456 ]
|   [ misc -- 11 ]
|          1: nnml:test 
|         10: nndraft:drafts 
| [...]
`----

[3] Tested with...

(global-set-key (kbd "<down>")
		(lambda (&optional arg)
		  (interactive)
		  (or arg (setq arg 1))
		  (next-line arg)
		  (redraw-frame (selected-frame))))
--8<---------------cut here---------------end--------------->8---

Re: tool bar icons not updated according to :active condition

[Kim F. Storm]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Mon, Feb 27 2006, Richard Stallman wrote:
>
>>     The following gives better results (but of course it is still a
>>     workaround, not a fix).
>>
>> What is the underlying bug, for which this is a workaround?
>
> The tool bar icons are not updated according to the :active condition.
> I'm including the original report below.


I wonder if you could use the `point-entered' and `point-left' hooks
on the relevant intervals/overlays in the Gnus summary buffer to
handle this specific case? 

They should run a hook which calls force-window-update if tool-bar
mode is enabled.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Sat, Mar 04 2006, Kim F. Storm wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
[...]
>> The tool bar icons are not updated according to the :active condition.
>> I'm including the original report below.
>
> I wonder if you could use the `point-entered' and `point-left' hooks
> on the relevant intervals/overlays in the Gnus summary buffer to
> handle this specific case? 
>
> They should run a hook which calls force-window-update if tool-bar
> mode is enabled.

Thanks for your suggestion.  I just checked in such a fix in Emacs CVS
(and Gnus v5-10 branch).  Feel free to improve it: I'm not sure if my
approach is the most simple one.

As Emacs 21 doesn't have `force-window-update', I used `redraw-frame'
there and set the default value of `gnus-group-update-tool-bar' to nil
in Emacs 21.  Is there a better way for Emacs 21?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: tool bar icons not updated according to :active condition

[Chong Yidong]

>   The following gives better results (but of course it is still a
>   workaround, not a fix).
>
> What is the underlying bug, for which this is a workaround?

I suggest adding "Add a function to redraw just the tool bar" to TODO.
Let's not consider this to be blocking the release.

Re: tool bar icons not updated according to :active condition

[Reiner Steib]

On Tue, Feb 28 2006, Chong Yidong wrote:

>>   The following gives better results (but of course it is still a
>>   workaround, not a fix).
>>
>> What is the underlying bug, for which this is a workaround?
>
> I suggest adding "Add a function to redraw just the tool bar" to TODO.
> Let's not consider this to be blocking the release.

Fine with me.  (This bug has already been there in Emacs 21.1 (and
version 5.9 of Gnus bundled with it) and I don't recall any complaints
about it.)

Bye, Reiner.

Re: tool bar icons not updated according to :active condition

[Richard Stallman]

    I suggest adding "Add a function to redraw just the tool bar" to TODO.

Such a function may be necessary, but the result would be rather
unsatisfactory.

A similar issue arises for the menu bar, and we have managed to handle
it more or less automatically.  Can't we do the same thing for the
toolbar?

Re: tool bar icons not updated according to :active condition

[Chong Yidong]

Richard Stallman <rms@gnu.org> writes:

>     I suggest adding "Add a function to redraw just the tool bar" to TODO.
>
> Such a function may be necessary, but the result would be rather
> unsatisfactory.
>
> A similar issue arises for the menu bar, and we have managed to handle
> it more or less automatically.

It's an entirely different issue.  The menus are redrawn each time the
user clicks to open the menu.  The point of this bug report is that
Reiner wants to redraw the tool bar after each command, not just when
the tool bar is clicked.