unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
To: tromey@redhat.com, <ding@gnus.org>
Cc: Emacs Hackers <emacs-devel@gnu.org>
Subject: Re: Patch to change mouse binding for html view in gnus
Date: Sun, 01 Jul 2007 23:48:19 +0200	[thread overview]
Message-ID: <v9y7hzbxss.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <m33b07c0ui.fsf@fleche.redhat.com> (Tom Tromey's message of "Sun,  01 Jul 2007 14:42:29 -0600")

[ Cc-ing the Gnus list; full quote. ]

On Sun, Jul 01 2007, Tom Tromey wrote:

> I have w3m installed, and so when Gnus sees an HTML message it is
> displayed via w3m.  This is quite nice.
>
> However, if I click on a link in an HTML message rendered this way,
> the target is displayed using w3m.  I generally don't want this; I
> only use w3m in Emacs for specialized things and in other cases I'd
> rather use my external web browser.

I'm not sure if doing this unconditionally is a good idea.  Shouldn't
it be customizable?

> This patch changes Gnus to use browse-url rather than w3m for links in
> buffers it renders.
>
> Tom
>
> 2007-07-01  Tom Tromey  <tromey@redhat.com>
>
> 	* mm-view.el (mm-inline-text-html-render-with-w3m): Locally set
> 	w3m-goto-article-function.
>
> cvs diff: Diffing .
> Index: mm-view.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/gnus/mm-view.el,v
> retrieving revision 1.29
> diff -u -r1.29 mm-view.el
> --- mm-view.el	19 Apr 2007 12:08:53 -0000	1.29
> +++ mm-view.el	1 Jul 2007 20:58:45 -0000
> @@ -252,6 +252,7 @@
>  	(let ((w3m-safe-url-regexp mm-w3m-safe-url-regexp)
>  	      w3m-force-redisplay)
>  	  (w3m-region (point-min) (point-max) nil charset))
> +	(set (make-local-variable 'w3m-goto-article-function) #'browse-url)
>  	(when (and mm-inline-text-html-with-w3m-keymap
>  		   (boundp 'w3m-minor-mode-map)
>  		   w3m-minor-mode-map)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

  reply	other threads:[~2007-07-01 21:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-01 20:42 Patch to change mouse binding for html view in gnus Tom Tromey
2007-07-01 21:48 ` Reiner Steib [this message]
2007-07-01 21:43   ` Tom Tromey
2007-07-02  2:59     ` Katsumi Yamaoka
2007-07-02 17:29       ` Tom Tromey
2007-07-03  4:33         ` Katsumi Yamaoka
2007-07-03 17:19           ` Tom Tromey
2007-07-03 23:18             ` Katsumi Yamaoka
2007-07-04  6:10               ` Katsumi Yamaoka
2007-07-12 16:05               ` Tom Tromey
2007-07-12 18:19                 ` Stefan Monnier
2007-07-12 22:42                   ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v9y7hzbxss.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).