* 23.0.50; tool bar icons disappear
@ 2007-12-08 11:56 Reiner Steib
2008-01-04 13:31 ` 23.0.50; tool bar icons disappear in customize buffers Reiner Steib
0 siblings, 1 reply; 8+ messages in thread
From: Reiner Steib @ 2007-12-08 11:56 UTC (permalink / raw)
To: emacs-devel
> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:
emacs -Q
M-x customize-variable RET savehist-mode RET
==> All tool bar icons disappear. The tool bar area and thus the
whole frame shrinks.
,----[ <f1> v tool-bar-map RET ]
| tool-bar-map is a variable defined in `[...]/emacs/lisp/tool-bar.elc'.
| Its value is shown below.
|
| Documentation:
| Keymap for the tool bar.
| Define this locally to override the global tool bar.
|
| Value: nil
| Local in buffer *Customize Option: Savehist Mode*; global value is
| (keymap
| (new-file menu-item "Visit New File..." find-file
| [...]
`----
,----[ <f1> v tool-bar-mode RET ]
| tool-bar-mode is a variable defined in `[...]/emacs/lisp/tool-bar.elc'.
| Its value is t
|
| Documentation:
| Non-nil if Tool-Bar mode is enabled.
| See the command `tool-bar-mode' for a description of this minor mode.
| Setting this variable directly does not take effect;
| either customize it (see the info node `Easy Customization')
| or call the function `tool-bar-mode'.
|
| You can customize this variable.
`----
I'd guess that the following changes might be relevant:
,----[ lisp/ChangeLog ]
| 2007-07-05 Chong Yidong <cyd@stupidchicken.com>
|
| * cus-edit.el (custom-commands): New variable.
| (custom-tool-bar-map): New variable. Initialize using
| `custom-commands'.
| (custom-mode): Use `custom-tool-bar-map'.
| [...]
`----
Is the following code in `cus-edit.el' correct? Is this code
evaluated at compile time (when `display-graphic-p' returns nil?)?
--8<---------------cut here---------------start------------->8---
(defvar tool-bar-map)
(defvar custom-tool-bar-map
(if (display-graphic-p)
(let ((map (make-sparse-keymap)))
(mapc
(lambda (arg)
(tool-bar-local-item-from-menu
(nth 1 arg) (nth 4 arg) map custom-mode-map))
custom-commands)
map)))
--8<---------------cut here---------------end--------------->8---
[BTW, using `when' would make the code more readable. Shouldn't the
variable have a doc string?]
,----[ <f1> v custom-tool-bar-map RET ]
| custom-tool-bar-map is a variable defined in `[...]/emacs/lisp/cus-edit.elc'.
| Its value is nil
|
| Documentation:
| Not documented as a variable.
`----
The problem doesn't exist neither in Emacs 22.1 nor in EMACS_22_BASE.
> In GNU Emacs 23.0.50.7 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
> of 2007-12-08 on viandante
> Windowing system distributor `The X.Org Foundation', version 11.0.70199902
> configured using `configure '--prefix=/import/xtra/emacs/HEAD'
> '--with-gtk' '--exec-prefix=/import/xtra/emacs/HEAD-i686'
> 'CFLAGS=-Wno-pointer-sign -O0 -fno-crossjumping -gdwarf-2 -g3''
> Important settings:
> value of $LC_ALL: nil
> value of $LC_COLLATE: nil
> value of $LC_CTYPE: nil
> value of $LC_MESSAGES: nil
> value of $LC_MONETARY: nil
> value of $LC_NUMERIC: nil
> value of $LC_TIME: nil
> value of $LANG: en_US.UTF-8
> locale-coding-system: utf-8
> default-enable-multibyte-characters: t
> Major mode: Custom
> Minor modes in effect:
> tooltip-mode: t
> tool-bar-mode: t
> mouse-wheel-mode: t
> menu-bar-mode: t
> file-name-shadow-mode: t
> global-font-lock-mode: t
> font-lock-mode: t
> blink-cursor-mode: t
> unify-8859-on-encoding-mode: t
> utf-translate-cjk-mode: t
> auto-compression-mode: t
> line-number-mode: t
> Recent input:
> M-x c u s t o m i z w <backspace> e - v a r i a b e
> l <backspace> <backspace> l e <return> s a v e h i
> s t - m o d e <return> <f1> v t o o l 0 <backspace>
> - b a r - m a <tab> <return> C-x 2 <f1> v t o o l -
> b a r - m o d e <return> <help-echo> <help-echo> <down-mouse-2>
> <mouse-2> M-x r e p o <tab> r <tab> <return>
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
> Creating customization items...
> Loading savehist...done
> Creating customization items ...done
> Resetting customization items...done
> Creating customization setup...done
> Type C-x 1 to delete the help window, C-M-v to scroll help.
> Making completion list...
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: 23.0.50; tool bar icons disappear in customize buffers
2007-12-08 11:56 23.0.50; tool bar icons disappear Reiner Steib
@ 2008-01-04 13:31 ` Reiner Steib
2008-01-04 18:28 ` martin rudalics
0 siblings, 1 reply; 8+ messages in thread
From: Reiner Steib @ 2008-01-04 13:31 UTC (permalink / raw)
To: emacs-devel; +Cc: Chong Yidong
Hi,
I didn't get a response to this in ~4 weeks:
On Sat, Dec 08 2007, Reiner Steib wrote:
>> Please describe exactly what actions triggered the bug
>> and the precise symptoms of the bug:
>
> emacs -Q
>
> M-x customize-variable RET savehist-mode RET
>
> ==> All tool bar icons disappear. The tool bar area and thus the
> whole frame shrinks.
>
> ,----[ <f1> v tool-bar-map RET ]
> | tool-bar-map is a variable defined in `[...]/emacs/lisp/tool-bar.elc'.
> | Its value is shown below.
> |
> | Documentation:
> | Keymap for the tool bar.
> | Define this locally to override the global tool bar.
> |
> | Value: nil
> | Local in buffer *Customize Option: Savehist Mode*; global value is
> | (keymap
> | (new-file menu-item "Visit New File..." find-file
> | [...]
> `----
>
> ,----[ <f1> v tool-bar-mode RET ]
> | tool-bar-mode is a variable defined in `[...]/emacs/lisp/tool-bar.elc'.
> | Its value is t
> |
> | Documentation:
> | Non-nil if Tool-Bar mode is enabled.
> | See the command `tool-bar-mode' for a description of this minor mode.
> | Setting this variable directly does not take effect;
> | either customize it (see the info node `Easy Customization')
> | or call the function `tool-bar-mode'.
> |
> | You can customize this variable.
> `----
>
> I'd guess that the following changes might be relevant:
>
> ,----[ lisp/ChangeLog ]
> | 2007-07-05 Chong Yidong <cyd@stupidchicken.com>
> |
> | * cus-edit.el (custom-commands): New variable.
> | (custom-tool-bar-map): New variable. Initialize using
> | `custom-commands'.
> | (custom-mode): Use `custom-tool-bar-map'.
> | [...]
> `----
>
> Is the following code in `cus-edit.el' correct? Is this code
> evaluated at compile time (when `display-graphic-p' returns nil?)?
>
> (defvar tool-bar-map)
> (defvar custom-tool-bar-map
> (if (display-graphic-p)
> (let ((map (make-sparse-keymap)))
> (mapc
> (lambda (arg)
> (tool-bar-local-item-from-menu
> (nth 1 arg) (nth 4 arg) map custom-mode-map))
> custom-commands)
> map)))
>
> [BTW, using `when' would make the code more readable. Shouldn't the
> variable have a doc string?]
>
> ,----[ <f1> v custom-tool-bar-map RET ]
> | custom-tool-bar-map is a variable defined in `[...]/emacs/lisp/cus-edit.elc'.
> | Its value is nil
> |
> | Documentation:
> | Not documented as a variable.
> `----
>
> The problem doesn't exist neither in Emacs 22.1 nor in EMACS_22_BASE.
>
>> In GNU Emacs 23.0.50.7 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
>> of 2007-12-08 on viandante
>> Windowing system distributor `The X.Org Foundation', version 11.0.70199902
>> configured using `configure '--prefix=/import/xtra/emacs/HEAD'
>> '--with-gtk' '--exec-prefix=/import/xtra/emacs/HEAD-i686'
>> 'CFLAGS=-Wno-pointer-sign -O0 -fno-crossjumping -gdwarf-2 -g3''
>
>> Important settings:
>> value of $LC_ALL: nil
>> value of $LC_COLLATE: nil
>> value of $LC_CTYPE: nil
>> value of $LC_MESSAGES: nil
>> value of $LC_MONETARY: nil
>> value of $LC_NUMERIC: nil
>> value of $LC_TIME: nil
>> value of $LANG: en_US.UTF-8
>> locale-coding-system: utf-8
>> default-enable-multibyte-characters: t
>
>> Major mode: Custom
>
>> Minor modes in effect:
>> tooltip-mode: t
>> tool-bar-mode: t
>> mouse-wheel-mode: t
>> menu-bar-mode: t
>> file-name-shadow-mode: t
>> global-font-lock-mode: t
>> font-lock-mode: t
>> blink-cursor-mode: t
>> unify-8859-on-encoding-mode: t
>> utf-translate-cjk-mode: t
>> auto-compression-mode: t
>> line-number-mode: t
>
>> Recent input:
>> M-x c u s t o m i z w <backspace> e - v a r i a b e
>> l <backspace> <backspace> l e <return> s a v e h i
>> s t - m o d e <return> <f1> v t o o l 0 <backspace>
>> - b a r - m a <tab> <return> C-x 2 <f1> v t o o l -
>> b a r - m o d e <return> <help-echo> <help-echo> <down-mouse-2>
>> <mouse-2> M-x r e p o <tab> r <tab> <return>
>
>> Recent messages:
>> For information about GNU Emacs and the GNU system, type C-h C-a.
>> Creating customization items...
>> Loading savehist...done
>> Creating customization items ...done
>> Resetting customization items...done
>> Creating customization setup...done
>> Type C-x 1 to delete the help window, C-M-v to scroll help.
>> Making completion list...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 23.0.50; tool bar icons disappear in customize buffers
2008-01-04 13:31 ` 23.0.50; tool bar icons disappear in customize buffers Reiner Steib
@ 2008-01-04 18:28 ` martin rudalics
2008-01-04 18:55 ` Reiner Steib
0 siblings, 1 reply; 8+ messages in thread
From: martin rudalics @ 2008-01-04 18:28 UTC (permalink / raw)
To: Reiner Steib; +Cc: Chong Yidong, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
>>Is the following code in `cus-edit.el' correct? Is this code
>>evaluated at compile time (when `display-graphic-p' returns nil?)?
>>
>>(defvar tool-bar-map)
>>(defvar custom-tool-bar-map
>> (if (display-graphic-p)
>> (let ((map (make-sparse-keymap)))
>> (mapc
>> (lambda (arg)
>> (tool-bar-local-item-from-menu
>> (nth 1 arg) (nth 4 arg) map custom-mode-map))
>> custom-commands)
>> map)))
I can't tell because tool-bars are displayed here. But you could verify
your claim by using something like the untested patch I attached.
[-- Attachment #2: cus-edit.patch --]
[-- Type: text/plain, Size: 1533 bytes --]
*** cus-edit.el.~1.337.~ Thu Nov 22 17:49:48 2007
--- cus-edit.el Fri Jan 4 19:25:34 2008
***************
*** 4459,4473 ****
custom-commands)))
(defvar tool-bar-map)
! (defvar custom-tool-bar-map
! (if (display-graphic-p)
! (let ((map (make-sparse-keymap)))
! (mapc
! (lambda (arg)
! (tool-bar-local-item-from-menu
! (nth 1 arg) (nth 4 arg) map custom-mode-map))
! custom-commands)
! map)))
;;; The Custom Mode.
--- 4459,4465 ----
custom-commands)))
(defvar tool-bar-map)
! (defvar custom-tool-bar-map nil)
;;; The Custom Mode.
***************
*** 4528,4534 ****
if that value is non-nil."
(use-local-map custom-mode-map)
(easy-menu-add Custom-mode-menu)
! (set (make-local-variable 'tool-bar-map) custom-tool-bar-map)
(make-local-variable 'custom-options)
(make-local-variable 'custom-local-buffer)
(make-local-variable 'widget-documentation-face)
--- 4520,4535 ----
if that value is non-nil."
(use-local-map custom-mode-map)
(easy-menu-add Custom-mode-menu)
! (when (display-graphic-p)
! (set (make-local-variable 'tool-bar-map)
! (or custom-tool-bar-map
! (let ((map (make-sparse-keymap)))
! (mapc
! (lambda (arg)
! (tool-bar-local-item-from-menu
! (nth 1 arg) (nth 4 arg) map custom-mode-map))
! custom-commands)
! (setq custom-tool-bar-map map)))))
(make-local-variable 'custom-options)
(make-local-variable 'custom-local-buffer)
(make-local-variable 'widget-documentation-face)
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: 23.0.50; tool bar icons disappear in customize buffers
2008-01-04 18:28 ` martin rudalics
@ 2008-01-04 18:55 ` Reiner Steib
2008-01-05 9:38 ` martin rudalics
0 siblings, 1 reply; 8+ messages in thread
From: Reiner Steib @ 2008-01-04 18:55 UTC (permalink / raw)
To: martin rudalics; +Cc: Chong Yidong, emacs-devel
On Fri, Jan 04 2008, martin rudalics wrote:
> I can't tell because tool-bars are displayed here.
You could try with "emacs -Q -xrm 'Emacs.toolBar:1'" ;-)
> But you could verify your claim by using something like the untested
> patch I attached.
The patch fixed the problem. Thanks.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: 23.0.50; tool bar icons disappear in customize buffers
2008-01-04 18:55 ` Reiner Steib
@ 2008-01-05 9:38 ` martin rudalics
2008-01-05 12:04 ` Reiner Steib
0 siblings, 1 reply; 8+ messages in thread
From: martin rudalics @ 2008-01-05 9:38 UTC (permalink / raw)
To: Reiner Steib; +Cc: Chong Yidong, emacs-devel
>>I can't tell because tool-bars are displayed here.
>
> You could try with "emacs -Q -xrm 'Emacs.toolBar:1'" ;-)
I meant that switching to a customization buffer did _not_ turn off the
tool-bar on my system. Hence, making seems to install different values
on our systems. Maybe this is also the cause that people didn't react
to your initial report.
>>But you could verify your claim by using something like the untested
>>patch I attached.
>
> The patch fixed the problem. Thanks.
Thanks to you for finding the cause of this. If no one objects I'll
install.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 23.0.50; tool bar icons disappear in customize buffers
2008-01-05 9:38 ` martin rudalics
@ 2008-01-05 12:04 ` Reiner Steib
2008-01-05 13:11 ` martin rudalics
0 siblings, 1 reply; 8+ messages in thread
From: Reiner Steib @ 2008-01-05 12:04 UTC (permalink / raw)
To: martin rudalics; +Cc: Chong Yidong, emacs-devel
On Sat, Jan 05 2008, martin rudalics wrote:
>>>I can't tell because tool-bars are displayed here.
[ Sorry, I miss-read this as "aren't", so this didn't make sense: ]
>> You could try with "emacs -Q -xrm 'Emacs.toolBar:1'" ;-)
> I meant that switching to a customization buffer did _not_ turn off the
> tool-bar on my system. Hence, making seems to install different values
> on our systems. Maybe this is also the cause that people didn't react
> to your initial report.
Ah, I wasn't aware of this. Anyhow it might be useful if someone
simply responds "can't reproduce this".
>>>But you could verify your claim by using something like the untested
>>>patch I attached.
>>
>> The patch fixed the problem. Thanks.
>
> Thanks to you for finding the cause of this.
Did I? ;-) Are you saying that my speculation "Is this code evaluated
at compile time (when `display-graphic-p' returns nil?)?" was correct?
> If no one objects I'll install.
Thanks.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: 23.0.50; tool bar icons disappear in customize buffers
2008-01-05 12:04 ` Reiner Steib
@ 2008-01-05 13:11 ` martin rudalics
2008-01-05 13:35 ` Reiner Steib
0 siblings, 1 reply; 8+ messages in thread
From: martin rudalics @ 2008-01-05 13:11 UTC (permalink / raw)
To: Reiner Steib; +Cc: Chong Yidong, emacs-devel
>>I meant that switching to a customization buffer did _not_ turn off the
>>tool-bar on my system. Hence, making seems to install different values
>>on our systems. Maybe this is also the cause that people didn't react
>>to your initial report.
>
> Ah, I wasn't aware of this. Anyhow it might be useful if someone
> simply responds "can't reproduce this".
Yes. But if no one responds we should, as a rule, repost.
>>Thanks to you for finding the cause of this.
>
>
> Did I? ;-) Are you saying that my speculation "Is this code evaluated
> at compile time (when `display-graphic-p' returns nil?)?" was correct?
You did, until someone proves you wrong ;-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 23.0.50; tool bar icons disappear in customize buffers
2008-01-05 13:11 ` martin rudalics
@ 2008-01-05 13:35 ` Reiner Steib
0 siblings, 0 replies; 8+ messages in thread
From: Reiner Steib @ 2008-01-05 13:35 UTC (permalink / raw)
To: martin rudalics; +Cc: emacs-devel
On Sat, Jan 05 2008, martin rudalics wrote:
>>>I meant that switching to a customization buffer did _not_ turn off the
>>>tool-bar on my system. Hence, making seems to install different values
>>>on our systems. Maybe this is also the cause that people didn't react
>>>to your initial report.
>>
>> Ah, I wasn't aware of this. Anyhow it might be useful if someone
>> simply responds "can't reproduce this".
>
> Yes. But if no one responds we should, as a rule, repost.
I did that, though maybe quite late. :-)
But I still think that *if* someone has tried and wasn't able to
reproduce the problem, it would make much sense to answer.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-01-05 13:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-08 11:56 23.0.50; tool bar icons disappear Reiner Steib
2008-01-04 13:31 ` 23.0.50; tool bar icons disappear in customize buffers Reiner Steib
2008-01-04 18:28 ` martin rudalics
2008-01-04 18:55 ` Reiner Steib
2008-01-05 9:38 ` martin rudalics
2008-01-05 12:04 ` Reiner Steib
2008-01-05 13:11 ` martin rudalics
2008-01-05 13:35 ` Reiner Steib
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).