Re: Changes to lisp/gnus/auth-source.el

Re: Changes to lisp/gnus/auth-source.el

[Glenn Morris]

> +;; Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
> +;;   2005, 2006, 2007, 2008 Free Software Foundation, Inc.

Have you really been developing this file, with its single defcustom,
for 12 years?

> +(eval-when-compile (require 'cl))

Not needed.

> +(defgroup auth-source nil
> +  "Authentication sources."
> +  :version "22.1"

"23.1" (and a "No Gnus" comment per Gnus convention?).

Re: Changes to lisp/gnus/auth-source.el

[Miles Bader]

Glenn Morris <rgm+gmane@gnu.org> writes:
>> +;; Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
>> +;;   2005, 2006, 2007, 2008 Free Software Foundation, Inc.
>
> Have you really been developing this file, with its single defcustom,
> for 12 years?

It must be a very refined defcustom... :-)

-Miles

-- 
"Though they may have different meanings, the cries of 'Yeeeee-haw!' and
 'Allahu akbar!' are, in spirit, not actually all that different."

Re: Changes to lisp/gnus/auth-source.el

[Ted Zlatanov]

On Sun, 09 Mar 2008 21:12:45 -0400 Glenn Morris <rgm+gmane@gnu.org> wrote: 

>> +(eval-when-compile (require 'cl))

GM> Not needed.

Not currently, but I will be using cl features.  Or do you mean it's
generally not needed anymore?

>> +(defgroup auth-source nil
>> +  "Authentication sources."
>> +  :version "22.1"

GM> "23.1" (and a "No Gnus" comment per Gnus convention?).

I'll make the change.

On Mon, 10 Mar 2008 10:33:15 +0900 Miles Bader <miles@gnu.org> wrote: 

MB> Glenn Morris <rgm+gmane@gnu.org> writes:
>>> +;; Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
>>> +;;   2005, 2006, 2007, 2008 Free Software Foundation, Inc.
>> 
>> Have you really been developing this file, with its single defcustom,
>> for 12 years?

MB> It must be a very refined defcustom... :-)

I'll have a defun in there by 2012 :)

Yes, so I copied gnus-registry.el, which copied others, for the
copyright assignment.  I thought the copyright notice was for the whole
Gnus tree, not for individual files.  If this is incorrect,
gnus-registry.el and other files may need to be adjusted too.

I'll commit the auth-source.el copyright date fix and the version fix
with my next commit.

Ted

Re: Changes to lisp/gnus/auth-source.el

[Reiner Steib]

On Mon, Mar 10 2008, Ted Zlatanov wrote:

> MB> Glenn Morris <rgm+gmane@gnu.org> writes:
>>>> +;; Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
>>>> +;;   2005, 2006, 2007, 2008 Free Software Foundation, Inc.
>>> 
>>> Have you really been developing this file, with its single defcustom,
>>> for 12 years?
[...]
> Yes, so I copied gnus-registry.el, which copied others, for the
> copyright assignment.  I thought the copyright notice was for the whole
> Gnus tree, not for individual files.  If this is incorrect,
> gnus-registry.el and other files may need to be adjusted too.

Please adjust the years in gnus-registry.el and the other files if
needed in the v5-10 branch.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Changes to lisp/gnus/auth-source.el

[Ted Zlatanov]

On Sat, 26 Apr 2008 22:12:50 +0200 Reiner Steib <reinersteib+gmane@imap.cc> wrote: 

RS> On Mon, Mar 10 2008, Ted Zlatanov wrote:
MB> Glenn Morris <rgm+gmane@gnu.org> writes:
>>>>> +;; Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
>>>>> +;;   2005, 2006, 2007, 2008 Free Software Foundation, Inc.
>>>> 
>>>> Have you really been developing this file, with its single defcustom,
>>>> for 12 years?
RS> [...]
>> Yes, so I copied gnus-registry.el, which copied others, for the
>> copyright assignment.  I thought the copyright notice was for the whole
>> Gnus tree, not for individual files.  If this is incorrect,
>> gnus-registry.el and other files may need to be adjusted too.

RS> Please adjust the years in gnus-registry.el and the other files if
RS> needed in the v5-10 branch.

Done in CVS head and in v5-10.

Thanks
Ted