From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Displaying MIME parts internally/externally in Gnus Date: Thu, 04 May 2006 13:01:29 +0200 Message-ID: References: <87irum4tka.fsf-monnier+emacs@gnu.org> <8764q7lenq.fsf-monnier+emacs@gnu.org> <873bgcns63.fsf-monnier+emacs@gnu.org> Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1146740520 11457 80.91.229.2 (4 May 2006 11:02:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 4 May 2006 11:02:00 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 04 13:01:56 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fbbah-0003MR-5V for ged-emacs-devel@m.gmane.org; Thu, 04 May 2006 13:01:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fbbag-0006kk-M1 for ged-emacs-devel@m.gmane.org; Thu, 04 May 2006 07:01:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FbbaU-0006gw-4n for emacs-devel@gnu.org; Thu, 04 May 2006 07:01:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FbbaS-0006fv-Ko for emacs-devel@gnu.org; Thu, 04 May 2006 07:01:37 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FbbaS-0006fs-EY for emacs-devel@gnu.org; Thu, 04 May 2006 07:01:36 -0400 Original-Received: from [134.60.1.1] (helo=mail.uni-ulm.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Fbbb2-0006dE-My for emacs-devel@gnu.org; Thu, 04 May 2006 07:02:13 -0400 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.6/8.13.6) with ESMTP id k44B1Tu6019001; Thu, 4 May 2006 13:01:29 +0200 (MEST) Original-Received: by bridgekeeper.physik.uni-ulm.de (Postfix, from userid 170) id 20B8711887; Thu, 4 May 2006 13:01:29 +0200 (CEST) Original-To: Stefan Monnier X-Face: P05mdcZT&lL[-s2=mw~RsllZ0zZAb?vdE}.s, ding@gnus.org, emacs-devel@gnu.org In-Reply-To: (Katsumi Yamaoka's message of "Thu, 04 May 2006 08:32:40 +0900") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) X-DCC-SIHOPE-DCC-3-Metrics: gemini 1085; Body=3 Fuz1=3 Fuz2=3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53889 gmane.emacs.gnus.general:63161 Archived-At: On Thu, May 04 2006, Katsumi Yamaoka wrote: >>>>>> Reiner Steib wrote: > >> I will apply Stefan's changes in the trunk now. Unless you object, I >> will apply both to v5-10 / Emacs-CVS as well. > > Well, how should we change the `mm-inlinable-p' function? > > In gnus-mime-view-part-internally: > gnus-art.el:4740:30:Warning: mm-inlinable-p called with 2 arguments, but > accepts only 1 It is this hunk in Stefan's patch: --8<---------------cut here---------------start------------->8--- @@ -4467,13 +4475,16 @@ (mm-inline-large-images t) (mail-parse-charset gnus-newsgroup-charset) (mail-parse-ignored-charsets - (save-excursion (set-buffer gnus-summary-buffer) + (with-current-buffer gnus-summary-buffer gnus-newsgroup-ignored-charsets)) (inhibit-read-only t)) + (if (not (mm-inlinable-p handle)) + (gnus-mime-view-part-as-type + nil (lambda (type) (mm-inlinable-p handle type))) (when handle (if (mm-handle-undisplayer handle) (mm-remove-part handle) - (mm-display-part handle))))) + (mm-display-part handle)))))) (defun gnus-mime-action-on-part (&optional action) "Do something with the MIME attachment at \(point\)." --8<---------------cut here---------------end--------------->8--- In `mm-inlinable-p', TYPE is the value of (mm-handle-media-type handle): --8<---------------cut here---------------start------------->8--- (defun mm-inlinable-p (handle) "Say whether HANDLE can be displayed inline." (let ((alist mm-inline-media-tests) (type (mm-handle-media-type handle)) test) (while alist (when (string-match (caar alist) type) (setq test (caddar alist) alist nil) (setq test (funcall test handle))) (pop alist)) test)) --8<---------------cut here---------------end--------------->8--- Stefan, maybe you forgot to send a patch for `mm-decode.el' as well? Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/