hard-newline changes in lisp/gnus/message.el

[Reiner Steib <reinersteib+gmane@imap.cc>]

Hi,

when changing lisp/gnus/*.el, please keep in mind that this directory
is synced by Miles Bader with the (primary) Gnus repository on
gnus.org in order to simplify the process of including a new stable
Gnus version in Emacs.  The stable version of Gnus (the v5-10 branch
in Gnus CVS) should be identical[1] to the version in Emacs CVS and it
should work with Emacs 20.7 and up and XEmacs 21.1 and up.

It would be nice to discuss possibly controversial changes on
emacs-devel and ding@gnus.org (Gnus development list) before
committing.

As for `hard-newline': Obviously `hard-newline' is not defined in
Emacs < 22.  I'm not sure what's the best way to deal with this.  I'd
suggest to define `message-hard-newline' in `message.el' as follows
and use it instead of `hard-newline'.

(defvar message-hard-newline
  (if (featurep 'xemacs)
      "\n" ;; Or better code for XEmacs
    (if (boundp 'hard-newline)
	hard-newline
      (propertize "\n" 'hard t 'rear-nonsticky '(hard)))))

Or:

(defvar message-hard-newline
  (cond ((boundp 'hard-newline) hard-newline)
	((fboundp 'propertize)
	 (propertize "\n" 'hard t 'rear-nonsticky '(hard)))
	(t "\n")))

BTW, maybe `hard-newline' should have a doc string?

Bye, Reiner.

[1] Exception: Version number.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/