From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: scratch/tzz/auth-source-reveal-mode 4a7c98d 3/3: Create and document auth-source-reveal-mode Date: Tue, 23 Jun 2020 22:29:50 +0000 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: References: <20200622191653.26453.39420@vcs0.savannah.gnu.org> <20200622191656.2D20920A26@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99008"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 24 00:31:13 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnrRg-000Pe7-N9 for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Jun 2020 00:31:12 +0200 Original-Received: from localhost ([::1]:37670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnrRf-00028C-Ly for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Jun 2020 18:31:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnrQS-0000W5-V4 for emacs-devel@gnu.org; Tue, 23 Jun 2020 18:29:57 -0400 Original-Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:44324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnrQR-0004j8-DA for emacs-devel@gnu.org; Tue, 23 Jun 2020 18:29:56 -0400 Original-Received: by mail-qt1-x82b.google.com with SMTP id j10so147350qtq.11 for ; Tue, 23 Jun 2020 15:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=krtwdLGfMb26uO4yFHBEfS+m4YCKgfmvDe7G9tzUXfE=; b=CHiavI9bIC5zZ6RoctotWL4rLG1P7phMN/8djkhETB2+RTgcp2WTLraC4xnOvF4rq4 NKJGPBYGUWxgjQjFn22ujK8WBqehaDoD3h/GnzEZZEi0Ux/CN5uhNGuX4UicYw7oWASZ m9XnWn+2nzTZikqVF3WrMDvti34G9WZTuScmI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=krtwdLGfMb26uO4yFHBEfS+m4YCKgfmvDe7G9tzUXfE=; b=Uwz6jcqHUXK4KLaBhRACO5ZR7egaicC67wC/pfuXTSgieeIj4a4rti1ktsBdYyC/Pp p78B2Rud5Uxog46TqKtf2OSCDeNy194nmOaqd9Y+F6i8talZh83X0sHovX4pleYjztLq yUt6VPJatXKl5Qn8QK/A2+L9TB3nPWhAq1kA/ZEqqaJM2kRozcol7FXsib9+YGKTOy2w 4nHXrCwaOIt2wA4A+EF3QWJFj4QIeYPgEXO0P/VXd6ipy0W+hh/spFrqCYS4QxIZoZm9 8UWAlm9uYx5WVbHyF1ZPnTaMe59bRHt1HtzrUyjCcpp4R585Phct5EJGf5s1aL82Cf2G cOtg== X-Gm-Message-State: AOAM532UpVrDEZIc//aUcUv+YMEm9a/Gex0vbMW++wcThn+z4Su55GFM pXJcjE/GEdwcbO7V+9cNAZclVLwjJ5w56w== X-Google-Smtp-Source: ABdhPJy0WE3eWnhkCdFdmrH0XEyTJfASpUPE23277yaQLCRyIOt0uuWNXkS8ZBkFby1QQjp35M+Xxg== X-Received: by 2002:aed:3bb9:: with SMTP id r54mr19815320qte.13.1592951393594; Tue, 23 Jun 2020 15:29:53 -0700 (PDT) Original-Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id 73sm1855068qkk.38.2020.06.23.15.29.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jun 2020 15:29:52 -0700 (PDT) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never In-Reply-To: (Stefan Monnier's message of "Mon, 22 Jun 2020 17:09:08 -0400") Received-SPF: none client-ip=2607:f8b0:4864:20::82b; envelope-from=tzz@lifelogs.com; helo=mail-qt1-x82b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252524 Archived-At: On Mon, 22 Jun 2020 17:09:08 -0400 Stefan Monnier wrote: SM> Yes, it's needed first: in some modes, enabling `prettify-symbols-mode` SM> can lead to really undesirable behavior (e.g. in Haskell it can lead to SM> code being plain wrong since it can affect indentation and indentation SM> is semantically significant like in Python). So you really can't impose SM> it on the unsuspecting user. Agreed. It was better to start with something cleaner. So, I created a whole new prettify-text API and reimplemented auth-source-reveal-mode on top of it. It worked well in my testing. The new branch is scratch/tzz/prettify-text-mode (I left scratch/tzz/auth-source-reveal-mode in place as a reference). The new code won't interfere with existing `prettify-symbols-mode' users. Eventually `prettify-symbols-mode' could be migrated to this new API to avoid the code duplication in the post-command-hook and elsewhere. If you have suggestions or comments, please let me know. I'll document the API before I push the branch out. Ted