From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Sat, 08 Mar 2008 12:35:10 +0100 Message-ID: References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> <87iqzzigv6.fsf@bzg.ath.cx> <87ejan7xhq.fsf@member.fsf.org> <87hcfi3egg.fsf@bzg.ath.cx> <87abla8w6b.fsf@member.fsf.org> <87bq5qhba6.fsf@bzg.ath.cx> <871w6m8t59.fsf@member.fsf.org> <87ablamphg.fsf@red-bean.com> <87skz2lacp.fsf@bzg.ath.cx> <87tzjil9oz.fsf@red-bean.com> <8763vyl964.fsf@bzg.ath.cx> <874pbiypad.fsf@bzg.ath.cx> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204976188 20312 80.91.229.12 (8 Mar 2008 11:36:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Mar 2008 11:36:28 +0000 (UTC) Cc: Karl Fogel , Tassilo Horn , Stefan Monnier , ding@gnus.org, emacs-devel@gnu.org To: Bastien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 08 12:36:53 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JXxM7-0005kf-CM for ged-emacs-devel@m.gmane.org; Sat, 08 Mar 2008 12:36:47 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXxLZ-0008Ub-Cf for ged-emacs-devel@m.gmane.org; Sat, 08 Mar 2008 06:36:13 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JXxLU-0008UN-6H for emacs-devel@gnu.org; Sat, 08 Mar 2008 06:36:08 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JXxLS-0008Tv-S8 for emacs-devel@gnu.org; Sat, 08 Mar 2008 06:36:07 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXxLS-0008Tn-J5 for emacs-devel@gnu.org; Sat, 08 Mar 2008 06:36:06 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JXxLS-0003LS-55 for emacs-devel@gnu.org; Sat, 08 Mar 2008 06:36:06 -0500 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m28BZwZ1027237; Sat, 8 Mar 2008 12:35:58 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 6C16212FE7; Sat, 8 Mar 2008 12:35:58 +0100 (CET) X-Face: 3Phac&+dw=IZHjhua]bp}LH<*p{qzj8u+ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91713 gmane.emacs.gnus.general:66456 Archived-At: On Thu, Mar 06 2008, Bastien wrote: > Stefan Monnier writes: >> Karl Fogel: >>> ;; This file implements real bookmarks for Gnus, closely following the way >>> ;; `bookmark.el' handles bookmarks. Most of the code comes from >>> ;; `bookmark.el'. >>> I'm not sure why GNUS bookmarks should live in a separate space from >>> other bookmarks, and my feeling is that they ought to be unified -- >> Indeed, it seems worthwhile to merge them, tho I've never used >> gnus-bookmarks. Bastien? > Two answers: yes gnus-bookmarks.el should stored Gnus bookmarks in > ~/.emacs.bmk (as every mode should do), but no we can't get rid of > gnus-bookmarks.el because it adds some keybindings to Gnus. On Sat, Mar 08 2008, Bastien wrote: > Following Karl advice I've applied a different patch. There is now > `bookmark-make-name-function' *and* `bookmark-make-record-function', > both buffer local. For an example on how this is supposed to work > look at the changes I've made in info.el. > > I think it's okay like this. If you plan to change anything please > tell me before I work on gnus-bookmark.el. I didn't follow this discussion closely. Do I understand correctly that after changing gnus-bookmark.el, it will take advantage of new features in bookmark.el that are not present in Emacs < 23. I.e. it wont work in Emacs 22 at all (and XEmacs?). As `gnus-bookmark.el' is quite new in No Gnus, I don't expect many Emacs <= 22 users use it intensively. If it is not too much work, it would be nice to make it work for all supported Emacsen, cf. (info "(gnus)Emacsen"). But I don't insist on this. If you don't support Emacs < 23, please ... - document that only Emacs 23 and up are supported, - make sure that it doesn't disturb compiling Gnus with Emacs < 23 too much, - signal appropriate errors when trying to use it in Emacs < 23. Bye, Reiner. P.S.: Please strip me from further CC's (I read the list(s)); instead include ding@gnus.org if the discussion is Gnus-related. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/