unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Warning: `mapcar' called for effect; use `mapc' or `dolist'
Date: Mon, 22 Oct 2007 22:55:29 +0200	[thread overview]
Message-ID: <v93aw2amym.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <200710222007.l9MK7fRZ022140@oogie-boogie.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 22 Oct 2007 13:07:40 -0700")

On Mon, Oct 22 2007, Dan Nicolaescu wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>   > On Mon, Oct 22 2007, Katsumi Yamaoka wrote:
>   > > For instance, `mapcar' used in `gnus-group-highlight-line'
>   > > cannot be replaced with `mapc' even if the compiler warns it.
>   > 
>   > Could the byte-compiler be improved not to warn about such cases?
>   > Here's the relevant code:
>   > 
>   > (defun gnus-group-highlight-line ()
>   >   "Highlight the current line according to `gnus-group-highlight'."
[...]
> It seems that `mailp' is not used in that function. 

`mailp' is used implicitly through the variable `gnus-group-highlight'
which is let-bound to `list'.  `list' is used in the body of the
let-form.

> Adding a use for it makes the warning go away...

Hm, I can't reproduce the warning using `emacs-lisp-byte-compile' with
GNU Emacs 23.0.50.6 (i686-pc-linux-gnu, GTK+ Version 2.10.6) of 2007-10-20.
Too old?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/



  reply	other threads:[~2007-10-22 20:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200710200643.l9K6h9gk021348@oogie-boogie.ics.uci.edu>
     [not found] ` <b4mtzojbb4c.fsf@jpl.org>
2007-10-22 18:49   ` Warning: `mapcar' called for effect; use `mapc' or `dolist' Reiner Steib
2007-10-22 20:07     ` Dan Nicolaescu
2007-10-22 20:55       ` Reiner Steib [this message]
2007-10-22 21:04         ` Dan Nicolaescu
2007-10-22 21:39           ` Glenn Morris
2007-10-23  1:01         ` Miles Bader
2007-10-23 10:39           ` Richard Stallman
2007-10-23 11:28             ` Miles Bader
2007-10-24  2:50               ` Richard Stallman
2007-10-23 10:39         ` Richard Stallman
     [not found]         ` <E1IkHAF-00040s-KJ@fencepost.gnu.org>
2007-10-27 10:46           ` Risky variables in Gnus (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Reiner Steib
2007-10-27 23:41             ` Richard Stallman
2007-10-28  0:02               ` Risky variables in Gnus Reiner Steib
2007-11-01 20:51                 ` Reiner Steib
2007-10-31  7:46         ` Warning: `mapcar' called for effect; use `mapc' or `dolist' Richard Stallman
2007-10-31 20:30           ` Reiner Steib
2007-10-31 21:19           ` Glenn Morris
2007-11-01  2:35           ` Katsumi Yamaoka
2007-10-24 19:28   ` Reiner Steib
2007-10-24 22:18     ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v93aw2amym.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=dann@ics.uci.edu \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).