From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Patch: minor blackbox.el fix Date: Tue, 08 Jan 2008 03:34:09 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1199781267 25295 80.91.229.12 (8 Jan 2008 08:34:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Jan 2008 08:34:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: tromey@redhat.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 08 09:34:48 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JC9v0-0007oD-ST for ged-emacs-devel@m.gmane.org; Tue, 08 Jan 2008 09:34:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JC9ud-00085w-Mu for ged-emacs-devel@m.gmane.org; Tue, 08 Jan 2008 03:34:19 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JC9uY-00084n-I5 for emacs-devel@gnu.org; Tue, 08 Jan 2008 03:34:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JC9uU-000831-JX for emacs-devel@gnu.org; Tue, 08 Jan 2008 03:34:12 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JC9uU-00082g-AN for emacs-devel@gnu.org; Tue, 08 Jan 2008 03:34:10 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JC9uT-00009F-Ou for emacs-devel@gnu.org; Tue, 08 Jan 2008 03:34:09 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1JC9uT-0008U1-3d; Tue, 08 Jan 2008 03:34:09 -0500 X-Spook: BCCI satellite imagery jihad bank Sundevil eavesdropping X-Ran: %eAn0`ZYfwR=Y\JO}m%h%=#V.41XM|rGb1qzDU12Z}tVk:#QuL[^aFA0|gd5r11ZDnO~a$ X-Hue: black X-Attribution: GM In-Reply-To: (Tom Tromey's message of "Sun, 06 Jan 2008 09:29:22 -0700") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:86558 Archived-At: Tom Tromey wrote: > This patch adds a "q" key binding to blackbox, to bury the buffer. OK. > Also, locally I found that RET was doing the wrong thing in blackbox, > and this patch arranges to redefine newline-and-indent as well. How is it that RET runs newline-and-indent and indent for you? Have you globally rebound it? Would changing from blackbox-redefine-key to (define-key map [return] 'bb-done) be better than adding a binding for newline-and-indent? > + (define-key map "q" 'bury-buffer) > (blackbox-redefine-key map 'newline 'bb-done) > + (blackbox-redefine-key map 'newline-and-indent 'bb-done)