Re: [PING] ClearType Patch

[Eli Zaretskii <eliz@gnu.org>]

> Date: Thu,  9 Jun 2005 09:10:28 +0100
> From: jasonr@f2s.com
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> 
> Quoting David Abrahams <dave@boost-consulting.com>:
> 
> > > #ifndef SPI_GETFONTSMOOTHINGTYPE
> > > #define SPI_GETFONTSMOOTHINGTYPE 0x0200A
> > > #endif
> >
> > Makes sense.  I just didn't know how close this was, legally speaking,
> > to copying MS code into GPL'd code, and didn't want to risk it.  But
> > if you say it's fine, I'm happy.
> 
> To be safe, I would write the code from the API documentation, not copy from the
> headers ;-) Or if the constants are in mingw headers, copy from there.
> 
> > > (which are really nothing more than a minor annoyance),
> >
> > Unless you happen to actually use ClearType, in which case it's
> > killer.
> 
> Killer implies that Emacs crashes or is otherwise unusable. In this case, a few
> characters (w and m mainly, or italics) have slightly thinner lines at the
> edges, since we are clipping pixels that the system claims are not there.
> 
> >
> > > so I'd be happier moving the check for Cleartype into
> > > w32_initialize() and just checking a file scope variable in
> > > w32_native_per_char_metric()
> >
> > Is there some appropriate windows event (like "application just came
> > to the foreground", however you spell that in Wind-ese)
> 
> There is a configuration change event that we could use to reevaluate all our
> settings that are made from system configuration. There are others that could
> benefit from this as well (system colors, scroll bar widths for example).

David, if it is now clear to you, based on these and other comments
from Jason, how to write an improved patch, please post it here and I
will install it.

If you still have questions, please ask here.

TIA